fix(i18n): improve warning logs and locale summary in translations sc… #5493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
🧱 stack: frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the temporary hotfix in
translations.mjsthat normalized irregular#counts (e.g.,####variable####→###variable###) and handled empty{}placeholders from GlotPress exports.It also improves the logging by:
debugmode is enabled.Context
The root cause of the placeholder issues originates from translation strings exported via GlotPress.
Once all placeholder inconsistencies are fixed upstream on translate.wordpress.org, this cleanup code will no longer be required.
Related issue
Fixes #5149