Skip to content

HTML API: Update customizable <select> parsing #9298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: trunk
Choose a base branch
from
Open

HTML API: Update customizable <select> parsing #9298

wants to merge 15 commits into from

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Jul 22, 2025

Trac ticket: #63736

The HTML standard is being updated to support customizable select elements. The HTML API should be updated to account for the new changes.

WHATWG/HTML PR 10548 had landed with the updates. Several browsers already have support and MDN pages have been updated for select, selectedcontent, and a new guide on customizable select elements.

There's also an html5-lib tests PR that updates tests to account for the changes.

Update HTML API parsing to account for changes in whatwg/html#10548.

Apply html5lib/html5lib-tests#178.

Todo:

  • Update the html5lib-tests README and sha when the PR lands.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@sirreal sirreal self-assigned this Jul 22, 2025
sirreal added 12 commits July 22, 2025 10:11
@sirreal
Update reset_insertion_mode_appropriately
9ab745d 
Remove SELECT case and update comments numbers.

The SELECT case was removed from the algorithm in the standard.
@sirreal
Deprecate the has_element_in_select_scope method
1acfce7 
This was removed from the HTML standard
@sirreal
Update "normal" end tag handling to include SELECT
aac853d
@sirreal
Update INPUT handling to account for SELECT
89c113d
@sirreal
Update HR tag handling
f75a08f
@sirreal
Update SELECT insertion handling
099f013
@sirreal
Update OPTION, OPTGROUP insertion handling
7fe3598
@sirreal
Remove in_select and in_select_in_table step methods
20e0807 
These insertion modes are removed from the standard.
@sirreal
Deprecate unused insertion mode constants
45edeae
@sirreal
Adjust html5lib-test expectation
446cdaa 
See https://github.com/html5lib/html5lib-tests/pull/178/files?show-viewed-files=true&file-filters%5B%5D=#r2222195057
@sirreal
Add close option tag comments, do not handle cloning
0ed0a68
@sirreal
Update has_element_in_scope with SELECT
8beb128
@github-actions GitHub Actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@sirreal
Bail when parsing SELECTEDCONTENT requiring clone
6be6287 
When SELECT > BUTTON > SELECTEDCONTENT is encountered, the selected
option may need to be cloned into the SELECTEDCONTENT. The HTML
processor does not support this action as it may require out of order
processing.
@sirreal sirreal marked this pull request as ready for review July 22, 2025 12:44
@sirreal sirreal requested a review from dmsnell July 22, 2025 12:44
@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jonsurrell.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@sirreal
Copy link
Member Author

sirreal commented Jul 22, 2025

This can be tested with the HTML API Debugger.

@sirreal sirreal mentioned this pull request Jul 22, 2025
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmsnell dmsnell Awaiting requested review from dmsnell

Assignees

@sirreal sirreal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sirreal