Skip to content

HTML API: Update customizable <select> parsing #9298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: trunk
Choose a base branch
from
Open

HTML API: Update customizable <select> parsing #9298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
aaee111
Apply patch from <select> parser PR
sirreal Jul 22, 2025
9ab745d
Update reset_insertion_mode_appropriately
sirreal Jul 22, 2025
1acfce7
Deprecate the has_element_in_select_scope method
sirreal Jul 22, 2025
aac853d
Update "normal" end tag handling to include SELECT
sirreal Jul 22, 2025
89c113d
Update INPUT handling to account for SELECT
sirreal Jul 22, 2025
f75a08f
Update HR tag handling
sirreal Jul 22, 2025
099f013
Update SELECT insertion handling
sirreal Jul 22, 2025
7fe3598
Update OPTION, OPTGROUP insertion handling
sirreal Jul 22, 2025
20e0807
Remove in_select and in_select_in_table step methods
sirreal Jul 22, 2025
45edeae
Deprecate unused insertion mode constants
sirreal Jul 22, 2025
446cdaa
Adjust html5lib-test expectation
sirreal Jul 22, 2025
0ed0a68
Add close option tag comments, do not handle cloning
sirreal Jul 22, 2025
8beb128
Update has_element_in_scope with SELECT
sirreal Jul 22, 2025
6be6287
Bail when parsing SELECTEDCONTENT requiring clone
sirreal Jul 22, 2025
9e79bb2
Update html5lib-tests
sirreal Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/wp-includes/html-api/class-wp-html-open-elements.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@ public function has_element_in_specific_scope( string $tag_name, $termination_li
* > - th
* > - marquee
* > - object
* > - select
* > - template
* > - MathML mi
* > - MathML mo
Expand Down Expand Up @@ -311,6 +312,7 @@ public function has_element_in_scope( string $tag_name ): bool {
'TH',
'MARQUEE',
'OBJECT',
'SELECT',
'TEMPLATE',

'math MI',
Expand Down Expand Up @@ -470,12 +472,14 @@ public function has_element_in_table_scope( string $tag_name ): bool {
* @since 6.4.0 Stub implementation (throws).
* @since 6.7.0 Full implementation.
*
* @see https://html.spec.whatwg.org/#has-an-element-in-select-scope
* @deprecated {WP_VERSION} This method is no longer part of the HTML standard.
*
* @param string $tag_name Name of tag to check.
* @return bool Whether the given element is in SELECT scope.
*/
public function has_element_in_select_scope( string $tag_name ): bool {
_deprecated_function( __METHOD__, '{WP_VERSION}' );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don’t know how the docblock tag and the function call interact. Do you feel like you have a strong understand? Are both expected/appropriate?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also be able to remove the body from this function and always return false since the actual select scope no longer exists


foreach ( $this->walk_up() as $node ) {
if ( $node->node_name === $tag_name ) {
return true;
Expand Down
6 changes: 4 additions & 2 deletions src/wp-includes/html-api/class-wp-html-processor-state.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,8 @@ class WP_HTML_Processor_State {
*
* @since 6.7.0
*
* @see https://html.spec.whatwg.org/#parsing-main-inselect
* @deprecated {WP_VERSION} The "in select" insertion mode was removed from the standard.
*
* @see WP_HTML_Processor_State::$insertion_mode
*
* @var string
Expand All @@ -220,7 +221,8 @@ class WP_HTML_Processor_State {
*
* @since 6.7.0
*
* @see https://html.spec.whatwg.org/#parsing-main-inselectintable
* @deprecated {WP_VERSION} The "in select in table" insertion mode was removed from the standard.
*
* @see WP_HTML_Processor_State::$insertion_mode
*
* @var string
Expand Down
Loading
Loading