[WIP] Fix JSL instruction not picking middle address byte#18
Closed
[WIP] Fix JSL instruction not picking middle address byte#18
Conversation
Co-authored-by: smokku <147687+smokku@users.noreply.github.com>
Co-authored-by: smokku <147687+smokku@users.noreply.github.com>
Co-authored-by: smokku <147687+smokku@users.noreply.github.com>
smokku
requested changes
Oct 14, 2025
Copilot stopped work on behalf of
smokku due to an error
October 14, 2025 23:12
Member
|
Fixed by #19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix JSL instruction to correctly handle 24-bit addresses
Summary
Fixed the JSL (Jump to Subroutine Long) instruction which was losing the middle byte of 24-bit addresses.
Problem
Solution
Changes Made
Result
✓ JSL $123456 now correctly sets PBR=$12, PC=$3456
The fix is complete, tested, and ready for merge.
Original prompt
Fixes #17
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.