Merged
Conversation
Fixes #17
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the JSL (Jump to Subroutine Long) instruction implementation in the W65C816S CPU emulator. The changes correct the cycle timing and execution sequence to match the official W65C816S datasheet specification.
- Adjusted JSL instruction cycle timing from 9 cycles to 8 cycles
- Fixed the order of operations during JSL execution to properly handle address calculation and stack operations
- Added comprehensive test coverage for the JSL instruction
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/codegen/w65c816s_gen.py | Updates the JSL instruction generator to fix the cycle sequence and timing |
| src/chips/w65c816s.h | Modifies the generated JSL instruction implementation with corrected cycle behavior |
| src/tests/cputest.cpp | Adds new test case to verify JSL instruction works correctly |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17