Do not override C++ standard in in-tree built. Also fix an issue preventing building with C++20 #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enting building with C++20
jorickert
commented
Oct 2, 2025
| endif() | ||
|
|
||
| project(torch-mlir LANGUAGES CXX C) | ||
| set(CMAKE_C_STANDARD 11) |
Author
There was a problem hiding this comment.
I did not apply the same change for the CMAKE_C_STANDARD , as downstream we use an older c version
mgehre-amd
reviewed
Oct 2, 2025
| project(torch-mlir LANGUAGES CXX C) | ||
| set(CMAKE_C_STANDARD 11) | ||
| set(CMAKE_CXX_STANDARD 17) | ||
| set(CMAKE_CXX_STANDARD 17 CACHE STRING "C++ standard to use") |
Collaborator
There was a problem hiding this comment.
How about just using 20 here if this is what we want? Then also CI builds of this repo will use the version we want?
See also my comment on onnx-mlir
Suggested change
| set(CMAKE_CXX_STANDARD 17 CACHE STRING "C++ standard to use") | |
| set(CMAKE_CXX_STANDARD 20) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.