Skip to content

Do not override C++ standard in in-tree built. Also fix an issue preventing building with C++20 #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: feature/backport_ea1_ops
Choose a base branch
from
Open

Do not override C++ standard in in-tree built. Also fix an issue preventing building with C++20 #618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ endif()

project(torch-mlir LANGUAGES CXX C)
set(CMAKE_C_STANDARD 11)
Copy link
Author

@jorickert jorickert Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not apply the same change for the CMAKE_C_STANDARD , as downstream we use an older c version

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD 17 CACHE STRING "C++ standard to use")
Copy link
Collaborator

@mgehre-amd mgehre-amd Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just using 20 here if this is what we want? Then also CI builds of this repo will use the version we want?
See also my comment on onnx-mlir

Suggested change
set(CMAKE_CXX_STANDARD 17 CACHE STRING "C++ standard to use")
set(CMAKE_CXX_STANDARD 20)


include(CMakeDependentOption)

Expand Down
2 changes: 1 addition & 1 deletion lib/RefBackend/RefBackend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ static std::string getConsumeReturnFunctionNameForReturnTypes(TypeRange types) {
tokens.push_back(getTypeToken(type));

return std::accumulate(tokens.begin(), tokens.end(), std::string(),
[](std::string &a, std::string &b) {
[](const std::string &a, const std::string &b) {
return a.empty() ? b : (a + "_" + b);
});
}
Expand Down
Loading