Skip to content

Conversation

@wanwiset25
Copy link
Collaborator

Proposed changes

verify timeout from epochInfo instead of snap.NextEpochCandidates
ref audit ticket: XFN-62

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@gzliudan gzliudan changed the title consensus: verify timeout from epochInfo instead of snap.NextEpochCandidates consensus: verify timeout from epochInfo instead of snap.NextEpochCandidates, close XFN-62 Nov 4, 2025
@gzliudan
Copy link
Collaborator

@wanwiset25 solve conflicts

@wanwiset25
Copy link
Collaborator Author

ref: #1724

@wanwiset25 wanwiset25 changed the title consensus: verify timeout from epochInfo instead of snap.NextEpochCandidates, close XFN-62 [WIP] consensus: verify timeout from epochInfo instead of snap.NextEpochCandidates, close XFN-62 Nov 16, 2025
@gzliudan gzliudan requested a review from liam-lai November 16, 2025 22:57
@wanwiset25 wanwiset25 changed the title [WIP] consensus: verify timeout from epochInfo instead of snap.NextEpochCandidates, close XFN-62 consensus: verify timeout from epochInfo instead of snap.NextEpochCandidates, close XFN-62 Nov 17, 2025
@XinFinOrg XinFinOrg deleted a comment from coderabbitai bot Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants