Skip to content

Conversation

@mambax7
Copy link
Contributor

@mambax7 mambax7 commented Dec 19, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 19, 2025 05:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds the missing ERROR_BAD_PHP language constant that is referenced in the VersionChecks::checkVerPhp() method but was not previously defined in the language files.

  • Adds the ERROR_BAD_PHP constant definition to both English and German language files
  • Ensures the common language file is loaded in checkVerPhp() method to make the constant available

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
language/english/common.php Adds the missing ERROR_BAD_PHP constant with English error message for PHP version requirements
language/german/common.php Adds the missing ERROR_BAD_PHP constant with German error message for PHP version requirements
class/Common/VersionChecks.php Loads the common language file to ensure ERROR_BAD_PHP constant is available when checking PHP version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


//Latest Version Check
\define('CO_' . $moduleDirNameUpper . '_' . 'NEW_VERSION', 'New Version: ');
\define('CO_' . $moduleDirNameUpper . '_' . 'ERROR_BAD_XOOPS', 'You need minimul version %s (your current version is %s)');
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a spelling error in the existing ERROR_BAD_XOOPS definition. The word "minimul" should be "minimum".

Suggested change
\define('CO_' . $moduleDirNameUpper . '_' . 'ERROR_BAD_XOOPS', 'You need minimul version %s (your current version is %s)');
\define('CO_' . $moduleDirNameUpper . '_' . 'ERROR_BAD_XOOPS', 'You need minimum version %s (your current version is %s)');

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant