Skip to content

Missing ERROR_BAD_PHP #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mambax7 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Missing ERROR_BAD_PHP #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46d06a3
Missing ERROR_BAD_PHP
mambax7 Dec 19, 2025
5379962
Implicitly marking parameter $module as nullable is deprecated, the e…
mambax7 Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion class/Common/VersionChecks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,15 @@ public static function checkVerXoops(\XoopsModule $module = null, string $requir
* @param \XoopsModule|null $module
* @return bool true if meets requirements, false if not
*/
public static function checkVerPhp(\XoopsModule $module = null): bool
public static function checkVerPhp(?\XoopsModule $module = null): bool
{
$moduleDirName = \basename(\dirname(__DIR__, 2));
$moduleDirNameUpper = \mb_strtoupper($moduleDirName);
if (null === $module) {
$module = \XoopsModule::getByDirname($moduleDirName);
}
\xoops_loadLanguage('admin', $moduleDirName);
\xoops_loadLanguage('common', $moduleDirName);
// check for minimum PHP version
$success = true;

Expand Down
2 changes: 2 additions & 0 deletions language/english/common.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,5 @@
//Latest Version Check
\define('CO_' . $moduleDirNameUpper . '_' . 'NEW_VERSION', 'New Version: ');
\define('CO_' . $moduleDirNameUpper . '_' . 'ERROR_BAD_XOOPS', 'You need minimul version %s (your current version is %s)');
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a spelling error in the existing ERROR_BAD_XOOPS definition. The word "minimul" should be "minimum".

Suggested change
\define('CO_' . $moduleDirNameUpper . '_' . 'ERROR_BAD_XOOPS', 'You need minimul version %s (your current version is %s)');
\define('CO_' . $moduleDirNameUpper . '_' . 'ERROR_BAD_XOOPS', 'You need minimum version %s (your current version is %s)');

Copilot uses AI. Check for mistakes.

\define('CO_' . $moduleDirNameUpper . '_' . 'ERROR_BAD_PHP', 'This module requires PHP version %s+ (%s installed)');
2 changes: 2 additions & 0 deletions language/german/common.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,5 @@
//Latest Version Check
\define('CO_' . $moduleDirNameUpper . '_' . 'NEW_VERSION', 'Neue Version: ');
\define('CO_' . $moduleDirNameUpper . '_' . 'ERROR_BAD_XOOPS', 'Sie benötigen mindestens Version %s (Ihre derzeitige Version ist %s)');

\define('CO_' . $moduleDirNameUpper . '_' . 'ERROR_BAD_PHP', 'Dieses Modul benötigt PHP Version %s+ (%s installiert)');