Skip to content

Conversation

@codegen-sh
Copy link

@codegen-sh codegen-sh bot commented May 13, 2025

This PR implements visualization capabilities for call graphs and dead code analysis, and fixes all mypy errors in the codebase.

Visualization Features

  • CodebaseVisualizer: Base abstract class for all visualizers
  • CallGraphFromNode: Creates call graphs from a starting function
  • CallGraphFilter: Filters call graphs to include only specific methods
  • CallPathsBetweenNodes: Shows paths between two functions
  • DeadCodeVisualizer: Identifies unused code in the codebase

Mypy Error Fixes

  • Added type annotation for graph in __init__.py
  • Fixed the path parameter in DiffLite.from_git_diff() to ensure it's never None
  • Added proper type annotations in issues.py for all variables flagged by mypy
  • Fixed DiDegreeView operator issues by extracting values first
  • Added proper type annotations for all visualizer classes

Additional Changes

  • Added comprehensive documentation for all visualizers
  • Created example usage in visualization_examples.py
  • Added README with usage examples

This PR replaces PR #111 and #112 with all the fixes for the mypy errors.


💻 View my workAbout Codegen

Note

I'm currently writing a description for your pull request. I should be done shortly (<1 minute). Please don't edit the description field until I'm finished, or we may overwrite each other. If I find nothing to write about, I'll delete this message.

Summary by Sourcery

Add visualization features for call graphs and dead code, fix all mypy type errors across the codebase, refactor core analyzers (issues, difflite, graph utilities) for stronger typing and cleaner models, and update documentation with usage examples.

New Features:

  • Introduce visualizers for call graphs (CallGraphFromNode, CallGraphFilter, CallPathsBetweenNodes) and dead code (DeadCodeVisualizer)
  • Add a base abstract class (CodebaseVisualizer) and package init
  • Provide example scripts demonstrating visualization capabilities

Bug Fixes:

  • Resolve mypy errors by adding comprehensive type annotations across analyzers, visualizers, and context modules
  • Ensure DiffLite.from_git_diff always yields a non-null path and fix related type mismatches

Enhancements:

  • Refactor the Issue and Location models for cleaner structure, unified enums, and automatic ID generation
  • Modernize diff utilities and graph context functions with improved logging, simplified methods, and new helper properties

Documentation:

  • Overhaul README to include installation, usage, and visualization sections
  • Add documentation for visualizer classes and examples in README and example files

clee-codegen and others added 30 commits February 26, 2025 23:54
# Motivation

The **Codegen on OSS** package provides a pipeline that:

- **Collects repository URLs** from different sources (e.g., CSV files
or GitHub searches).
- **Parses repositories** using the codegen tool.
- **Profiles performance** and logs metrics for each parsing run.
- **Logs errors** to help pinpoint parsing failures or performance
bottlenecks.

<!-- Why is this change necessary? -->

# Content

<!-- Please include a summary of the change -->
see
[codegen-on-oss/README.md](https://github.com/codegen-sh/codegen-sdk/blob/acfe3dc07b65670af33b977fa1e7bc8627fd714e/codegen-on-oss/README.md)

# Testing

<!-- How was the change tested? -->
`uv run modal run modal_run.py`
No unit tests yet 😿 

# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [x] I have updated the documentation or added new documentation as
needed
Original commit by Tawsif Kamal: Revert "Revert "Adding Schema for Tool Outputs"" (codegen-sh#894)

Reverts codegen-sh#892

---------

Co-authored-by: Rushil Patel <[email protected]>
Co-authored-by: rushilpatel0 <[email protected]>
Original commit by Ellen Agarwal: fix: Workaround for relace not adding newlines (codegen-sh#907)
@korbit-ai
Copy link

korbit-ai bot commented May 13, 2025

By default, I don't review pull requests opened by bots. If you would like me to review this pull request anyway, you can request a review via the /korbit-review command in a comment.

@sourcery-ai
Copy link

sourcery-ai bot commented May 13, 2025

Reviewer's Guide

This PR introduces a new visualization subsystem for call graphs and dead-code analysis, overhauls documentation with usage examples, and resolves all existing mypy type errors by adding and tightening type annotations across the codebase.

File-Level Changes

Change Details Files
Visualization subsystem for call graphs and dead-code analysis
  • Added abstract CodebaseVisualizer base class
  • Implemented CallGraphFromNode, CallGraphFilter, CallPathsBetweenNodes, DeadCodeVisualizer
  • Published example usage in examples/visualization_examples.py
  • Exported new visualizers in init.py
codegen_on_oss/visualizers/codebase_visualizer.py
codegen_on_oss/visualizers/call_graph_from_node.py
codegen_on_oss/visualizers/dead_code.py
codegen_on_oss/visualizers/__init__.py
examples/visualization_examples.py
Fixed mypy errors by adding precise type annotations and handling optional values
  • Annotated all classes and functions with Optional, List, Dict, Union, and Enum types
  • Ensured DiffLite.from_git_diff never returns None for path and added new_content field
  • Refactored Issue, Location, IssueCollection, and create_issue to use explicit types and simplified from_dict
analyzers/issues.py
analyzers/diff_lite.py
analyzers/context/graph/__init__.py
Documentation and README improvements
  • Reworked README with concise installation and usage examples for both analysis and visualization
  • Expanded docstrings on major classes and methods to describe arguments and return values
README.md
**/*.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai
Copy link

coderabbitai bot commented May 13, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codegen-sh
Copy link
Author

codegen-sh bot commented May 13, 2025

Hey! 👋 I see one of the checks failed. I am on it! 🫡

💻 View my work

@codegen-sh
Copy link
Author

codegen-sh bot commented May 13, 2025

✅ Fixed the failing checks in PR #113 with this commit. The issues were:

  1. Fixed deprecated typing imports in graph/__init__.py (replaced List, Set, Tuple with their lowercase equivalents)
  2. Added specific error codes to type ignore comments in issues.py
  3. Combined nested if statements in dead_code.py for better readability
  4. Fixed formatting issues in README.md
  5. Updated type annotations in diff_lite.py to use the newer | syntax instead of Optional

These changes should resolve the pre-commit and mypy check failures.

💻 View my work • React 👍 or 👎

@codegen-sh
Copy link
Author

codegen-sh bot commented May 13, 2025

Hey! 👋 I see one of the checks failed. I am on it! 🫡

💻 View my work

@codegen-sh
Copy link
Author

codegen-sh bot commented May 13, 2025

🧩 I need a bit more direction!

This task is complex - could you break it down into smaller steps?
For best results, try to add specific context, explicitly mention symbol names, etc.

Reach out to our Slack community channel for any help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants