Skip to content

fix: fractional number as id -> invalid request #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandonh-msft merged 6 commits into from
Aug 7, 2025
Merged

fix: fractional number as id -> invalid request #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5c798fa
fractional number as id -> invalid request
brandonh-msft Jul 30, 2025
70baf02
include channels pkg only for netstandard 2
brandonh-msft Jul 30, 2025
bc08c1b
nowarn for argumentnullexception.throwif removed
brandonh-msft Jul 30, 2025
8b17711
remove extra blank line
brandonh-msft Jul 30, 2025
2d46d04
Merge branch 'main' into fix/45-jsonrpcrequest-id-can-be-string-number
brandonh-msft Jul 31, 2025
0f3d40e
Merge branch 'main' into fix/45-jsonrpcrequest-id-can-be-string-number
brandonh-msft Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 35 additions & 37 deletions src/A2A/A2A.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,46 +1,44 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net9.0;net8.0;netstandard2.0</TargetFrameworks>
<PropertyGroup>
<TargetFrameworks>net9.0;net8.0;netstandard2.0</TargetFrameworks>

<!-- NuGet Package Properties -->
<PackageId>A2A</PackageId>
<Description>.NET SDK for the Agent2Agent (A2A) protocol.</Description>
<PackageTags>Agent2Agent;a2a;agent;ai;llm;aspnetcore</PackageTags>
<PackageReadmeFile>README.md</PackageReadmeFile>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<!-- Don't suggest using ArgumentNullException.ThrowIfNull as we target NS2.0 where it's not present -->
<NoWarn>$(NoWarn);CA1510</NoWarn>
</PropertyGroup>
<!-- NuGet Package Properties -->
<PackageId>A2A</PackageId>
<Description>.NET SDK for the Agent2Agent (A2A) protocol.</Description>
<PackageTags>Agent2Agent;a2a;agent;ai;llm;aspnetcore</PackageTags>
<PackageReadmeFile>README.md</PackageReadmeFile>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>

<PropertyGroup Condition="'$(TargetFramework)' != 'netstandard2.0'">
<IsAotCompatible>true</IsAotCompatible>
</PropertyGroup>
<!-- Dependencies only needed by netstandard2.0 -->
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
<PackageReference Include="System.Text.Json" />
<PropertyGroup Condition="'$(TargetFramework)' != 'netstandard2.0'">
<IsAotCompatible>true</IsAotCompatible>
</PropertyGroup>

<!-- Dependencies only needed by netstandard2.0 -->
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
<PackageReference Include="System.Text.Json" />
<PackageReference Include="System.Threading.Channels" />
</ItemGroup>
</ItemGroup>

<!-- Dependencies needed by all -->
<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Caching.Abstractions" />
<PackageReference Include="Microsoft.Extensions.ExtraAnalyzers">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.Extensions.Logging" />
<PackageReference Include="System.Linq.AsyncEnumerable" />
<PackageReference Include="System.Net.ServerSentEvents" />
<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup>
<!-- Dependencies needed by all -->
<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Caching.Abstractions" />
<PackageReference Include="Microsoft.Extensions.ExtraAnalyzers">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.Extensions.Logging" />
<PackageReference Include="System.Linq.AsyncEnumerable" />
<PackageReference Include="System.Net.ServerSentEvents" />
<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup>

<ItemGroup>
<None Include="..\..\README.md" Pack="true" PackagePath="\" />
</ItemGroup>
<ItemGroup>
<None Include="..\..\README.md" Pack="true" PackagePath="\" />
</ItemGroup>

</Project>
5 changes: 3 additions & 2 deletions src/A2A/JsonRpc/JsonRpcRequestConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,12 @@ private static JsonRpcId ReadAndValidateIdField(JsonElement rootElement)
{
if (rootElement.TryGetProperty("id", out var idElement))
{
if (idElement.ValueKind != JsonValueKind.String &&
if ((idElement.ValueKind != JsonValueKind.String &&
idElement.ValueKind != JsonValueKind.Number &&
idElement.ValueKind != JsonValueKind.Null)
|| (idElement.ValueKind is JsonValueKind.Number && !idElement.TryGetInt64(out var _)))
{
throw new A2AException("Invalid JSON-RPC request: 'id' field must be a string, number, or null.", A2AErrorCode.InvalidRequest);
throw new A2AException("Invalid JSON-RPC request: 'id' field must be a string, non-fractional number, or null.", A2AErrorCode.InvalidRequest);
}

return idElement.ValueKind switch
Expand Down
3 changes: 2 additions & 1 deletion tests/A2A.AspNetCore.UnitTests/A2AJsonRpcProcessorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ public class A2AJsonRpcProcessorTests
{
[Theory]
[InlineData("\"test-id\"", true)] // String ID - valid
//[InlineData(42, true)] // Number ID - valid: Uncomment when numeric IDs are supported
[InlineData(42, true)] // Number ID - valid: Uncomment when numeric IDs are supported
[InlineData(42.1, false)] // Fractional number ID - invalid (should throw error)
[InlineData("null", true)] // Null ID - valid
[InlineData("true", false)] // Boolean ID - invalid (should throw error)
public async Task ValidateIdField_HandlesVariousIdTypes(object? idValue, bool isValid)
Expand Down
3 changes: 2 additions & 1 deletion tests/A2A.UnitTests/JsonRpc/JsonRpcRequestConverterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,7 @@ public void Read_InvalidMethod_ThrowsA2AException(string methodJson)
[Theory]
[InlineData("true")]
[InlineData("[]")]
[InlineData("42.1")]
public void Read_InvalidIdType_ThrowsA2AException(string idJson)
{
// Arrange
Expand All @@ -288,7 +289,7 @@ public void Read_InvalidIdType_ThrowsA2AException(string idJson)
JsonSerializer.Deserialize<JsonRpcRequest>(json, _options));

Assert.Equal(A2AErrorCode.InvalidRequest, exception.ErrorCode);
Assert.Contains("'id' field must be a string, number, or null", exception.Message);
Assert.Contains("'id' field must be a string, non-fractional number, or null", exception.Message);
}

[Theory]
Expand Down