Skip to content

Conversation

@kabir
Copy link
Collaborator

@kabir kabir commented Jul 7, 2025

Description

Although quarkus-resteasy uses non-reactive RestEasy, Quarkus's CDi container is more lenient than the spec.

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests pass
  • Appropriate READMEs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

ehsavoie added 4 commits July 7, 2025 11:07
Signed-off-by: Emmanuel Hugonnet <[email protected]>
Signed-off-by: Emmanuel Hugonnet <[email protected]>
Signed-off-by: Emmanuel Hugonnet <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant architectural shift for the sdk-jakarta module, transitioning its testing and runtime environment from Quarkus to WildFly. This involves a comprehensive update of the build system, test setup, and dependency management to fully embrace the Jakarta EE application server paradigm. Additionally, the changes include minor logging enhancements and refactorings in shared test infrastructure to accommodate the new multi-server testing approach.

Highlights

  • Migration to WildFly for sdk-jakarta: The sdk-jakarta module has been reconfigured to use WildFly as its application server for testing, replacing the previous Quarkus-based setup. This includes adding WildFly and Arquillian dependencies, configuring Maven plugins for WildFly provisioning, and setting up Arquillian for test deployment.
  • Updated Test Infrastructure: The JakartaA2AServerTest class has been refactored to use Arquillian for deployment, dynamically packaging the application as a WebArchive with necessary classes and configuration files (beans.xml, web.xml). A new JAX-RS RestApplication class was also added.
  • Common Test Class Enhancements: The AbstractA2AServerTest class was updated to be more flexible, allowing subclasses (like the Jakarta and Quarkus test classes) to specify the server port. Debugging logs were also added to RestAssured calls for better test visibility.
  • CDI and Logging Configuration: New beans.xml files were added or modified across relevant modules (core, sdk-jakarta, tests/server-common) to ensure proper CDI bean discovery with bean-discovery-mode="all". Specific logging configurations for WildFly were introduced via a CLI script and logging.properties to aid in debugging the new server environment.
  • Code Simplification: The EventQueue class in sdk-server-common was simplified by removing an unused parent field and its associated constructor logic.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the sdk-jakarta module from using Quarkus to WildFly for its server implementation and testing environment. This involves significant changes to the pom.xml to replace Quarkus dependencies with Arquillian and WildFly dependencies, and updating the test classes to use Arquillian's deployment mechanism. The changes look good and are consistent with the goal of the PR. I've added a few suggestions to improve code clarity and maintainability.

Arquillian.xml to enable debugging
@Deployment
public static WebArchive createTestArchive() throws IOException {
final List<String> prefixes = List.of(
"a2a-java-sdk-core",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update this to a2a-java-sdk-spec for #149. I'll add a note there after merging this one.

@fjuma fjuma merged commit be11861 into a2aproject:main Jul 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants