-
Notifications
You must be signed in to change notification settings - Fork 104
feat: Rework tests so they don't rely on running in container #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly reworks the testing infrastructure to remove its reliance on specific container environments for integration tests. By introducing a set of REST endpoints that expose server-side test utilities, I've enabled tests to interact with the application's internal state (like task storage and queue management) via HTTP. This change enhances test portability across different Java runtimes and improves the overall stability and maintainability of the test suite.
Highlights
- Test Architecture Rework: I've refactored the integration tests to no longer rely on direct dependency injection of server components like
TaskStoreandQueueManager. Instead, tests now interact with the server via dedicated HTTP REST endpoints, promoting a more black-box testing approach. - New Test Utility Endpoints: I've introduced new test utility endpoints on the server side. Specifically,
TestUtilsBean(a common component) provides methods to manipulate tasks and queues, which are exposed viaA2ATestRoutesfor Quarkus, allowing tests to control server state through HTTP requests. - Improved Streaming Test Reliability: I've implemented a more robust mechanism for tests to await and confirm streaming subscriptions. This change addresses previous intermittent test failures related to the timing of streaming connections, making the tests more stable and reliable.
- Decoupled Test Setup: The
QuarkusA2AServerTestclass has been simplified by removing direct injections of internal server components. It now inherits and utilizes the new HTTP-based helper methods fromAbstractA2AServerTest, further decoupling the tests from the specific runtime environment.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The code changes introduce REST endpoints for test setup and assertions. I've identified areas for improvement, primarily around error handling in the new test routes and robustness of the asynchronous test helpers. Addressing these points will make the new test infrastructure more reliable and easier to debug.
reference-impl/src/test/java/io/a2a/server/apps/quarkus/A2ATestRoutes.java
Show resolved
Hide resolved
tests/server-common/src/test/java/io/a2a/server/apps/common/AbstractA2AServerTest.java
Outdated
Show resolved
Hide resolved
tests/server-common/src/test/java/io/a2a/server/apps/common/AbstractA2AServerTest.java
Show resolved
Hide resolved
tests/server-common/src/test/java/io/a2a/server/apps/common/AbstractA2AServerTest.java
Show resolved
Hide resolved
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the tests to remove the dependency on running inside a container. This is a great improvement for test portability. The approach of exposing test-setup utilities via REST endpoints is sound.
My review has identified a few issues:
- A critical logic bug in the new
awaitStreamingSubscriptionmethod that will cause timeouts. - Several high and medium severity issues in the new test REST endpoints (
A2ATestRoutes), including incorrect route paths and non-ideal HTTP responses. - Some medium severity issues in the test helper methods in
AbstractA2AServerTestrelated to error messages.
I've provided specific suggestions to address these points. Once these are fixed, the PR should be in good shape.
tests/server-common/src/test/java/io/a2a/server/apps/common/AbstractA2AServerTest.java
Outdated
Show resolved
Hide resolved
reference-impl/src/test/java/io/a2a/server/apps/quarkus/A2ATestRoutes.java
Outdated
Show resolved
Hide resolved
reference-impl/src/test/java/io/a2a/server/apps/quarkus/A2ATestRoutes.java
Show resolved
Hide resolved
reference-impl/src/test/java/io/a2a/server/apps/quarkus/A2ATestRoutes.java
Show resolved
Hide resolved
tests/server-common/src/test/java/io/a2a/server/apps/common/AbstractA2AServerTest.java
Show resolved
Hide resolved
tests/server-common/src/test/java/io/a2a/server/apps/common/AbstractA2AServerTest.java
Outdated
Show resolved
Hide resolved
…ject#185) # Description While running the tests in a container is possible in Quarkus, and in WildFly (with Arquillian), this might not be possible for all Java runtimes. Hence, this PR changes the tests so the interactions with the TaskStore, QueueManager, and being notified about the subscription to a streaming request happening. Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Follow the [`CONTRIBUTING` Guide](../CONTRIBUTING.md). - [x] Make your Pull Request title in the <https://www.conventionalcommits.org/> specification. - Important Prefixes for [release-please](https://github.com/googleapis/release-please): - `fix:` which represents bug fixes, and correlates to a [SemVer](https://semver.org/) patch. - `feat:` represents a new feature, and correlates to a SemVer minor. - `feat!:`, or `fix!:`, `refactor!:`, etc., which represent a breaking change (indicated by the `!`) and will result in a SemVer major. - [x] Ensure the tests pass - [x] Appropriate READMEs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕
Description
While running the tests in a container is possible in Quarkus, and in WildFly (with Arquillian), this might not be possible for all Java runtimes.
Hence, this PR changes the tests so the interactions with the TaskStore, QueueManager, and being notified about the subscription to a streaming request happening.
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.Fixes #<issue_number_goes_here> 🦕