fix: bug189

[Linux2010]

Description

• fix: bug#189

• Follow the CONTRIBUTING Guide.

• Make your Pull Request title in the https://www.conventionalcommits.org/ specification.

  • Important Prefixes for release-please:
    • fix: which represents bug fixes, and correlates to a SemVer patch.
    • feat: represents a new feature, and correlates to a SemVer minor.
    • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.

• Ensure the tests pass

• Appropriate READMEs were updated (if necessary)

Fixes #189 🦕

[gemini-code-assist]

Summary of Changes

Hello @Linux2010, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves bug #189 by enhancing the path handling logic within the A2ACardResolver class. The change specifically addresses an edge case where a leading slash in the agentCardPath could lead to incorrect URI construction, improving the robustness of the client's resource location mechanism.

Highlights

• Bug Fix: Path Resolution: Implemented a check in the A2ACardResolver constructor to remove a leading slash from the agentCardPath if present, ensuring correct URI resolution.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes a bug in URL construction where an absolute agent card path would incorrectly override the path of the base URL. The change correctly strips the leading slash from the agentCardPath to ensure it's treated as a relative path. My review includes a suggestion to make this logic more robust by handling cases with multiple leading slashes.

[sunyuhan1998]

LGTM!

[kabir]

Hi @Linux2010 thank you for the pull request! Could you please add some tests to A2ACardResolverTest for the case described in the issue?

@fjuma You've been looking more at this recently, so please check

[Linux2010]

I carefully reviewed the source code and referred to the logic of a2a-python. I believe that bug#189 is not a problem.

Each agent occupies a port independently, so the path '/it_agent' should be placed in agentCardPath instead of baseUrl. Please verify my thinking. If there is no problem, please close this PR and bug#189

[fjuma]

@Linux2010 Thanks for working on this and for looking into it in more detail!

I agree with your assessment, in this case, the /it_agent part should be specified in the agentCardPath instead of in the baseUrl.

I'll go ahead and close this PR and the associated bug.

Thanks very much!

[ChenKangQiang]

In most scenarios, the default agentCardPath is fixed to /.well-known/agent.json. The only difference is the base url. Like mcp, the default mcp endpoint is /sse, but it supports configurable baseUrl. Users need to be allowed to only pass in the baseUrl.

[fjuma]

In most scenarios, the default agentCardPath is fixed to /.well-known/agent.json. The only difference is the base url. Like mcp, the default mcp endpoint is /sse, but it supports configurable baseUrl. Users need to be allowed to only pass in the baseUrl.

It is possible to only pass the baseUrl:

https://github.com/a2aproject/a2a-java/blob/main/client/src/main/java/io/a2a/client/A2ACardResolver.java#L32

Let me know if I'm missing something.