-
Notifications
You must be signed in to change notification settings - Fork 104
chore: add logging to TaskManager #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a previously identified omission by integrating logging capabilities into the TaskManager class. The changes introduce SLF4J-based logging to provide clearer insights into artifact management processes and to flag potential issues, aligning the TaskManager with the project's established logging strategy.
Highlights
- Logging Integration: Integrated SLF4J logging into the
TaskManagerclass to provide better visibility into task management operations, aligning with the project's established logging strategy. - Artifact Management Visibility: Added debug logs within the
saveTaskEventmethod to trace operations such as replacing, adding, and appending parts to artifacts. - Error/Warning Logging: Introduced a warning log to alert when an attempt is made to append to a non-existent artifact, which helps in identifying and debugging potential data inconsistencies.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds valuable logging to the TaskManager, which will greatly improve traceability and debugging. The implementation is solid, using SLF4J with parameterized messages. I've left a couple of minor suggestions to clean up an unused import and fix a typo in a log message. Overall, great work!
sdk-server-common/src/main/java/io/a2a/server/tasks/TaskManager.java
Outdated
Show resolved
Hide resolved
sdk-server-common/src/main/java/io/a2a/server/tasks/TaskManager.java
Outdated
Show resolved
Hide resolved
91ef04f to
a09726d
Compare
sunyuhan1998
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
# Description I noticed while reviewing a2aproject#181 and looking at the Python implementation that we don't have logging in the TaskManager. We decided on the logging strategy after the initial code was written. This PR addresses this omission.
Description
I noticed while reviewing #181 and looking at the Python implementation that we don't have logging in the TaskManager. We decided on the logging strategy after the initial code was written. This PR addresses this omission.