Skip to content

chore: add logging to TaskManager #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kabir merged 1 commit into from
Jul 29, 2025
Merged

chore: add logging to TaskManager #205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion sdk-server-common/src/main/java/io/a2a/server/tasks/TaskManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,13 @@
import io.a2a.spec.TaskArtifactUpdateEvent;
import io.a2a.spec.TaskStatus;
import io.a2a.spec.TaskStatusUpdateEvent;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

public class TaskManager {

private static final Logger LOGGER = LoggerFactory.getLogger(TaskManager.class);

private volatile String taskId;
private volatile String contextId;
private final TaskStore taskStore;
Expand Down Expand Up @@ -101,16 +106,18 @@ Task saveTaskEvent(TaskArtifactUpdateEvent event) throws A2AServerException {
// This represents the first chunk for this artifact index
if (existingArtifactIndex >= 0) {
// Replace the existing artifact entirely with the new artifact
LOGGER.debug("Replacing artifact at id {} for task {}", artifactId, taskId);
artifacts.set(existingArtifactIndex, newArtifact);
} else {
// Append the new artifact since no artifact with this id/index exists yet
LOGGER.debug("Adding artifact at id {} for task {}", artifactId, taskId);
artifacts.add(newArtifact);
}

} else if (existingArtifact != null) {
// Append new parts to the existing artifact's parts list
// Do this to a copy

LOGGER.debug("Appending parts to artifact id {} for task {}", artifactId, taskId);
List<Part<?>> parts = new ArrayList<>(existingArtifact.parts());
parts.addAll(newArtifact.parts());
Artifact updated = new Artifact.Builder(existingArtifact)
Expand All @@ -120,6 +127,9 @@ Task saveTaskEvent(TaskArtifactUpdateEvent event) throws A2AServerException {
} else {
// We received a chunk to append, but we don't have an existing artifact.
// We will ignore this chunk
LOGGER.warn(
"Received append=true for nonexistent artifact index for artifact {} in task {}. Ignoring chunk.",
artifactId, taskId);
}

task = new Task.Builder(task)
Expand Down