Skip to content

Conversation

@fjuma
Copy link
Collaborator

@fjuma fjuma commented Oct 10, 2025

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests pass
  • Appropriate READMEs were updated (if necessary)

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fjuma, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the TaskUpdater utility by providing additional methods for managing task-related information. It introduces a way to retrieve the task's context ID and simplifies the process of adding artifacts by offering a more convenient addArtifact overload.

Highlights

  • New getContextId method: Added a public method getContextId() to the TaskUpdater class, allowing retrieval of the task's context identifier.
  • Overloaded addArtifact method: Introduced a new addArtifact(List<Part<?>> parts) method to TaskUpdater, providing a simpler way to add artifacts without specifying artifactId, name, or metadata.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new getter for contextId and a convenience overload for the addArtifact method in the TaskUpdater class. While the changes are functionally simple, they lack corresponding unit tests, which is a significant omission for ensuring code quality and preventing regressions. I've also noted a minor style inconsistency. My primary feedback is to add tests for the new logic.

Comment on lines +61 to +67
public String getContextId() {
return this.contextId;
}

public void addArtifact(List<Part<?>> parts) {
addArtifact(parts, null, null, null);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The newly added methods getContextId() and addArtifact(List<Part<?>> parts) are not covered by unit tests. Adding tests is essential for verifying the functionality and preventing future regressions. Please add corresponding tests to TaskUpdaterTest.java.

}

public String getContextId() {
return this.contextId;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The explicit use of this is not necessary here and is inconsistent with the prevailing style in the project (e.g., in RequestContext.java), where it's omitted in simple getters. To maintain a consistent coding style, it's better to remove it.

Suggested change
return this.contextId;
return contextId;

@kabir kabir merged commit 5522df7 into a2aproject:main Oct 13, 2025
9 of 11 checks passed
ethanthopkins added a commit to ethanthopkins/a2a-java that referenced this pull request Oct 15, 2025
…ject#336).

Update tck/src/main/java/io/a2a/tck/server/AgentExecutorProducer.java

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update tck/src/main/java/io/a2a/tck/server/AgentCardProducer.java

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

feat: Add some additional methods to TaskUpdater (a2aproject#339)

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make
sure it goes smoothly:

- [x] Follow the [`CONTRIBUTING` Guide](../CONTRIBUTING.md).
- [x] Make your Pull Request title in the
<https://www.conventionalcommits.org/> specification.
- Important Prefixes for
[release-please](https://github.com/googleapis/release-please):
- `fix:` which represents bug fixes, and correlates to a
[SemVer](https://semver.org/) patch.
- `feat:` represents a new feature, and correlates to a SemVer minor.
- `feat!:`, or `fix!:`, `refactor!:`, etc., which represent a breaking
change (indicated by the `!`) and will result in a SemVer major.
- [x] Ensure the tests pass
- [x] Appropriate READMEs were updated (if necessary)

test: Disable flaky KafkaReplicationIntegrationTest (a2aproject#346)

Removes unused imports
ethanthopkins added a commit to ethanthopkins/a2a-java that referenced this pull request Oct 15, 2025
…ject#336).

Update tck/src/main/java/io/a2a/tck/server/AgentExecutorProducer.java

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update tck/src/main/java/io/a2a/tck/server/AgentCardProducer.java

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

feat: Add some additional methods to TaskUpdater (a2aproject#339)

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make
sure it goes smoothly:

- [x] Follow the [`CONTRIBUTING` Guide](../CONTRIBUTING.md).
- [x] Make your Pull Request title in the
<https://www.conventionalcommits.org/> specification.
- Important Prefixes for
[release-please](https://github.com/googleapis/release-please):
- `fix:` which represents bug fixes, and correlates to a
[SemVer](https://semver.org/) patch.
- `feat:` represents a new feature, and correlates to a SemVer minor.
- `feat!:`, or `fix!:`, `refactor!:`, etc., which represent a breaking
change (indicated by the `!`) and will result in a SemVer major.
- [x] Ensure the tests pass
- [x] Appropriate READMEs were updated (if necessary)

test: Disable flaky KafkaReplicationIntegrationTest (a2aproject#346)

Removes unused imports

removes unused import
ethanthopkins added a commit to ethanthopkins/a2a-java that referenced this pull request Oct 16, 2025
…ject#336).

Update tck/src/main/java/io/a2a/tck/server/AgentExecutorProducer.java

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update tck/src/main/java/io/a2a/tck/server/AgentCardProducer.java

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

feat: Add some additional methods to TaskUpdater (a2aproject#339)

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make
sure it goes smoothly:

- [x] Follow the [`CONTRIBUTING` Guide](../CONTRIBUTING.md).
- [x] Make your Pull Request title in the
<https://www.conventionalcommits.org/> specification.
- Important Prefixes for
[release-please](https://github.com/googleapis/release-please):
- `fix:` which represents bug fixes, and correlates to a
[SemVer](https://semver.org/) patch.
- `feat:` represents a new feature, and correlates to a SemVer minor.
- `feat!:`, or `fix!:`, `refactor!:`, etc., which represent a breaking
change (indicated by the `!`) and will result in a SemVer major.
- [x] Ensure the tests pass
- [x] Appropriate READMEs were updated (if necessary)

test: Disable flaky KafkaReplicationIntegrationTest (a2aproject#346)

Removes unused imports

removes unused import
kabir pushed a commit to kabir/a2a-java that referenced this pull request Dec 23, 2025
# Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make
sure it goes smoothly:

- [x] Follow the [`CONTRIBUTING` Guide](../CONTRIBUTING.md).
- [x] Make your Pull Request title in the
<https://www.conventionalcommits.org/> specification.
- Important Prefixes for
[release-please](https://github.com/googleapis/release-please):
- `fix:` which represents bug fixes, and correlates to a
[SemVer](https://semver.org/) patch.
- `feat:` represents a new feature, and correlates to a SemVer minor.
- `feat!:`, or `fix!:`, `refactor!:`, etc., which represent a breaking
change (indicated by the `!`) and will result in a SemVer major.
- [x] Ensure the tests pass
- [x] Appropriate READMEs were updated (if necessary)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants