Skip to content

feat: Add some additional methods to TaskUpdater #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kabir merged 1 commit into from
Oct 13, 2025
Merged

feat: Add some additional methods to TaskUpdater #339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions server-common/src/main/java/io/a2a/server/tasks/TaskUpdater.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,14 @@ private void updateStatus(TaskState state, Message message, boolean isFinal) {
}
}

public String getContextId() {
return this.contextId;
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The explicit use of this is not necessary here and is inconsistent with the prevailing style in the project (e.g., in RequestContext.java), where it's omitted in simple getters. To maintain a consistent coding style, it's better to remove it.

Suggested change
return this.contextId;
return contextId;

}

public void addArtifact(List<Part<?>> parts) {
addArtifact(parts, null, null, null);
}
Comment on lines +61 to +67
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The newly added methods getContextId() and addArtifact(List<Part<?>> parts) are not covered by unit tests. Adding tests is essential for verifying the functionality and preventing future regressions. Please add corresponding tests to TaskUpdaterTest.java.


public void addArtifact(List<Part<?>> parts, String artifactId, String name, Map<String, Object> metadata) {
addArtifact(parts, artifactId, name, metadata, null, null);
}
Expand Down