Skip to content

refactor: reverse execution order of interceptors in the after interceptor#244

Merged
guglielmo-san merged 3 commits intoa2aproject:mainfrom
guglielmo-san:execute_interceptors_in_opposite_order
Dec 10, 2025
Merged

refactor: reverse execution order of interceptors in the after interceptor#244
guglielmo-san merged 3 commits intoa2aproject:mainfrom
guglielmo-san:execute_interceptors_in_opposite_order

Conversation

@guglielmo-san
Copy link
Member

Description

This PR reverses the execution order of interceptors in the interceptAfter method. It ensures symmetry with interceptBefore, meaning the last interceptor called during the 'before' phase is the first one called during the 'after' phase.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @guglielmo-san, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the _interceptAfter method to reverse the order in which 'after' interceptors are executed. This change establishes a symmetrical interception flow, where the processing order for 'after' interceptors mirrors the inverse of 'before' interceptors. The update includes modifying the core logic and adjusting a corresponding test case to validate the new behavior.

Highlights

  • Interceptor Execution Order: The execution order of 'after' interceptors has been reversed to ensure symmetry with 'before' interceptors. This means the last interceptor called during the 'before' phase will now be the first one called during the 'after' phase.
  • Code Refinement: The _interceptAfter method now explicitly creates a reversed list of interceptors for processing, simplifying the logic and removing a redundant check for empty interceptor arrays.
  • Test Alignment: A relevant test case has been updated to reflect the new reversed execution order of 'after' interceptors, ensuring the expected behavior is correctly validated.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly refactors the interceptAfter method to reverse the execution order of interceptors, establishing a symmetrical LIFO (Last-In, First-Out) pattern relative to the interceptBefore phase. The implementation is robust, handling various scenarios of provided or configured interceptors gracefully by safely creating a reversed shallow copy. The accompanying test modifications in multitransport-client.spec.ts are appropriate and ensure the test suite correctly validates the new execution order. Overall, this is a solid improvement to the interceptor logic.

@guglielmo-san guglielmo-san requested a review from ishymko December 9, 2025 17:52
Co-authored-by: Ivan Shymko <vana.shimko@gmail.com>
@guglielmo-san guglielmo-san enabled auto-merge (squash) December 10, 2025 09:00
@guglielmo-san guglielmo-san merged commit cdbaf64 into a2aproject:main Dec 10, 2025
6 checks passed
@guglielmo-san guglielmo-san deleted the execute_interceptors_in_opposite_order branch December 10, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants