Skip to content

refactor: reverse execution order of interceptors in the after interceptor #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guglielmo-san merged 3 commits into from
Dec 10, 2025
Merged

refactor: reverse execution order of interceptors in the after interceptor #244

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d264d8
change order of interceptors
guglielmo-san Dec 9, 2025
dbd38b4
Update src/client/multitransport-client.ts
guglielmo-san Dec 10, 2025
4d09ac5
Merge branch 'main' into execute_interceptors_in_opposite_order
guglielmo-san Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/client/multitransport-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,10 +382,8 @@ export class Client {
args: AfterArgs<K>,
interceptors?: CallInterceptor[]
): Promise<void> {
if (!this.config?.interceptors || this.config.interceptors.length === 0) {
return;
}
for (const interceptor of interceptors ?? this.config.interceptors) {
const reversedInterceptors = [...(interceptors || this.config?.interceptors || [])].reverse();
for (const interceptor of reversedInterceptors) {
await interceptor.after(args);
if (args.earlyReturn) {
return;
Expand Down
8 changes: 4 additions & 4 deletions test/client/multitransport-client.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,15 +569,15 @@ describe('Client', () => {
{
before: async () => {},
after: async (args) => {
args.earlyReturn = true;
if (args.result.method === 'getTask') {
args.result.value = { ...args.result.value, metadata: { foo: 'bar' } };
}
},
},
{
before: async () => {},
after: async (args) => {
if (args.result.method === 'getTask') {
args.result.value = { ...args.result.value, metadata: { foo: 'bar' } };
}
args.earlyReturn = true;
},
},
],
Expand Down