- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 613
 
Update license db generation #3197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    * Removes is_builtin attribute from details * Removes the text attribute as there already was a license_text displayed so this wasn't necessary Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
d5bfa72    to
    593c019      
    Compare
  
    
      
        
      
      
  
    2 tasks
  
              
                    pombredanne
  
              
              requested changes
              
                  
                    Jan 12, 2023 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nit pickings for your review.
Thanks!
        
          
                tests/licensedcode/data/license_db/license_dump/bison-exception-2.0.json
          
            Show resolved
            Hide resolved
        
      * Removes CLI option `--dump-license-data` * Adds new console script `scancode-license-data --path PATH` * Updates CHANGELOG Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
593c019    to
    5af8ca6      
    Compare
  
    Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
              
                    pombredanne
  
              
              approved these changes
              
                  
                    Jan 16, 2023 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Reference: #2738
--dump-license-datascancode-license-data-dumpSigned-off-by: Ayan Sinha Mahapatra [email protected]
Tasks
Run tests locally to check for errors.