-
-
Notifications
You must be signed in to change notification settings - Fork 616
Add tests for all PyPI METADATA versions (#4175) #4180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for all PyPI METADATA versions (#4175) #4180
Conversation
c05f2be to
be42f1d
Compare
|
@AyanSinhaMahapatra I am trying to add all PyPI METADATA versions, am I doing this correct & any more suggestions on this issue. What I improved in this issue. |
be42f1d to
90f320e
Compare
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alok1304 Thanks++
See comments for some improvements, looking great otherwise.
tests/packagedcode/data/pypi/metadata/v23/PKG-INFO-expected.json
Outdated
Show resolved
Hide resolved
tests/packagedcode/data/pypi/unpacked_wheel/metadata-2.2/trimesh-4.6.1.dist-info/METADATA
Show resolved
Hide resolved
9e70764 to
76bc57b
Compare
|
@alok1304 can you also post the links of the wheels and sdist you have been using for tests? |
|
@pombredanne, Here are links to all wheels and sdist.
|
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alok1304 see my review comments, please make you test files smaller by getting rid of large text portions which are not useful.
tests/packagedcode/data/pypi/metadata/v23/PKG-INFO-expected.json
Outdated
Show resolved
Hide resolved
bdbf1dc to
81183fb
Compare
|
Hey @AyanSinhaMahapatra I reduce the description text. |
Ref: aboutcode-org#4175 Signed-off-by: Alok Kumar <[email protected]>
81183fb to
c97e9bc
Compare
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks++ @alok1304, merging!
Fixes #4175
Tasks
Run tests locally to check for errors.
Signed-off-by: Alok Kumar [email protected]