Skip to content

Conversation

@alok1304
Copy link
Collaborator

@alok1304 alok1304 commented Mar 6, 2025

Fixes #4175

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

Signed-off-by: Alok Kumar [email protected]

@alok1304 alok1304 force-pushed the pypi-metadata-tests-4175 branch from c05f2be to be42f1d Compare March 6, 2025 17:15
@alok1304
Copy link
Collaborator Author

alok1304 commented Mar 6, 2025

@AyanSinhaMahapatra I am trying to add all PyPI METADATA versions, am I doing this correct & any more suggestions on this issue. What I improved in this issue.

@alok1304 alok1304 force-pushed the pypi-metadata-tests-4175 branch from be42f1d to 90f320e Compare March 6, 2025 18:00
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alok1304 Thanks++

See comments for some improvements, looking great otherwise.

@pombredanne
Copy link
Member

@alok1304 can you also post the links of the wheels and sdist you have been using for tests?
This is useful for reference!

@alok1304
Copy link
Collaborator Author

@pombredanne, Here are links to all wheels and sdist.

  1. Metadata-Version: 2.2
    Name: ForeTiS
    Version: 0.0.7
    wheel & sdist: https://github.com/grimmlab/ForeTiS/tree/master/dist

  2. Metadata-Version: 2.3
    Name: hatchling
    Version: 1.22.4
    wheel & sdist: https://pypi.org/project/hatchling/1.22.4/#files

  3. Metadata-Version: 2.2
    Name: trimesh
    Version: 4.6.1
    wheel & sdist: https://pypi.org/project/trimesh/4.6.1/#files

  4. Metadata-Version: 2.4
    Name: narwhals
    Version: 1.29.0
    wheel & sdist: https://pypi.org/project/narwhals/1.29.0/#files

Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alok1304 see my review comments, please make you test files smaller by getting rid of large text portions which are not useful.

@alok1304 alok1304 force-pushed the pypi-metadata-tests-4175 branch from bdbf1dc to 81183fb Compare April 7, 2025 12:36
@alok1304
Copy link
Collaborator Author

alok1304 commented Apr 7, 2025

Hey @AyanSinhaMahapatra I reduce the description text.

@alok1304 alok1304 force-pushed the pypi-metadata-tests-4175 branch from 81183fb to c97e9bc Compare April 11, 2025 18:11
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks++ @alok1304, merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 3582983 into aboutcode-org:develop Apr 16, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure all versions of pypi METADATA parsing is tested

3 participants