Fix broken HIDPowerDevice_::sendDate method #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forderud
force-pushed
the
sendDate-fix
branch
2 times, most recently
from
a4288f4 to
71c2682
Compare
forderud
force-pushed
the
sendDate-fix
branch
from
fc77679 to
98a351a
Compare
|
@abratchik Would it be possible for you to take a look at either this PR or #29? I've already tested the change locally. |
The method currently uses a local "bval" variable as argument when calling HID().SendReport(...). This is problematic, since the SendReport method doesn't use "bval" immediately. It instead captures a pointer to "bval" which is accessed when the report is sent at a later point. This leads to a use-after-free situation when the pointer captured by SendReport may no longer point to "bval". Propose to fix the issue by introducing a new "iManufacturerDate" member in the HIDPowerDevice class to act as persistent storage for the date value.
… instead of a INPUT report, so that it matches the ManufacturerDate parameter in the HID descriptor. This is also required in order for the date to be picked up on Windows.
…nt8_t month, uint8_t day)" since it's anyhow tied to the ManufacturerDate parameter.
forderud
force-pushed
the
sendDate-fix
branch
from
98a351a to
8bbade6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #29 for an alternative proposal.
The method currently uses a local
bvalvariable as argument when callingHID().SendReport(...). This is problematic, since theSendReportmethod doesn't usebvalimmediately. It instead captures a pointer tobvalwhich is accessed when the report is sent at a later point. This leads to a use-after-free situation when the pointer captured bySendReportno longer point tobval, but some other unknown data.Propose to fix the issue by introducing a new
iManufacturerDatemember in theHIDPowerDeviceclass to act as persistent storage for the date value.Also, change
HIDPowerDevice_::sendDateto send the date as aFEATUREreport instead of aINPUTreport, so that it matches theManufacturerDateparameter in the HID descriptor. This is also required in order for the date to be picked up on Windows.