Remove unused and broken HIDPowerDevice_::sendDate method #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abratchik Would it be possible for you to take a look at either this PR or #28? I've already tested the change locally. |
The method currently uses a local bval variable as argument when calling HID().SendReport(...). This is problematic, since the SendReport method doesn't use bval immediately. It instead captures a pointer to bval which is accessed when the report is sent at a later point. This leads to a use-after-free situation when the pointer captured by SendReport no longer point to bval, but some other unknown data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #28.
The method currently uses a local
bvalvariable as argument when callingHID().SendReport(...). This is problematic, since theSendReportmethod doesn't usebvalimmediately. It instead captures a pointer tobvalwhich is accessed when the report is sent at a later point. This leads to a use-after-free situation when the pointer captured bySendReportno longer point tobval, but some other unknown data.Proposing to delete the
sendDatemethod, since it's both broken and unused. Client code can anyhow set date parameters through manualsetFeaturecalls as was done in #25.