Medical - Fix ace_medical_fnc_serializeState modifying unit medications array#11309
Merged
PabstMirror merged 3 commits intoacemod:masterfrom Mar 9, 2026
Merged
Medical - Fix ace_medical_fnc_serializeState modifying unit medications array#11309PabstMirror merged 3 commits intoacemod:masterfrom
PabstMirror merged 3 commits intoacemod:masterfrom
Conversation
PabstMirror
approved these changes
Mar 8, 2026
Contributor
|
looks good |
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
tbeswick96
added a commit
to tbeswick96/ACE3
that referenced
this pull request
Mar 17, 2026
Serialize wound entries, medications, triage card, IV bags, occluded medications, and log entries as named hashmaps instead of positional arrays. Deserializer supports both formats via isEqualType guards. - Wounds: [classComplex, amountOf, bleedingRate, woundDamage] → hashmap - Medications: [med, timeOffset, ttme, mtis, hr, pain, flow, dose] → hashmap - TriageCard: [item, count, timestamp] → hashmap - IvBags: [volume, type, partIndex, treatment, rateCoef, item] → hashmap - OccludedMedications: [partIndex, className] → hashmap - Logs: [logType, entries] → hashmap with entry hashmaps Also includes upstream merge (upstream/master → uksfcustom) which brings: - Fix serializeState modifying unit medications array (acemod#11309) - Add API to directly add wounds to units (acemod#11211) - Markers: allow placing quick number markers (acemod#11019) - Maverick displayname consistency (acemod#11310) - arma-rs 1.12.1, extension bump Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
I noticed that running serializeState on a unit will modify the unit's medications array with the "time" offsets. Issue was due to arrays being references. Fixes issue #11308