[my_preferences] Translate to my_preferences module #10015

SKADE2303 · 2025-09-15T14:03:39Z

This PR is responsible for translating the module my_preferences to different languages. Currently only 'Hindi' language is supported but other languages can be added as required.

Testing instructions (if applicable)

Run 'make dev' to load changes
Change language_preference to Hindi in my_preferences Tab
Go to my_preferences tab to see translated web page.

racostas

Hi @SKADE2303 , as requested in #10009
Save and Reset should be in loris.po ns not in the module itself since this two worlds are used all across the LORIS system. Thank you.

racostas · 2025-09-16T14:35:02Z

There are also missing translations

racostas · 2025-09-23T14:39:14Z

@SKADE2303 , automatic tests still failing here.

racostas · 2025-09-29T04:44:03Z

Conflicts need to be resolved. Needs rebase. Also the test that are failing here does are related to this PR.

racostas · 2025-09-30T14:10:52Z

Is this one ready to be re-reviewed ?
Also the unrelated text failing are fixed already. Please relaunch the tests.

racostas

I assume it's not ready yet.

There are some missing translations:

racostas

This change don't seems to be consistent. The key in the .pot and the .po files are different.

racostas · 2025-10-23T14:52:25Z

More untranslated words, again please carefully test.

racostas · 2025-10-23T16:56:40Z

modules/my_preferences/locale/my_preferences.pot

+msgid "User name"
+msgstr ""
+
+msgid "First name"
+msgstr ""
+
+msgid "First name is required and should not exceed 120 characters"
+msgstr ""
+
+msgid "Last name"
+msgstr ""
+
+msgid "Last name is required and should not exceed 120 characters"
+msgstr ""
+
+msgid "Email address"
+msgstr ""
+
+msgid "Email address is required"
+msgstr ""
+


There are lot of terms here that are common with user_account, please put all that is common in loris.pot/ loris.po and use this in both modules: my_preferences and user_account

For reference this is the user_account PR #9934

racostas · 2025-10-23T16:58:38Z

this PR is blocking #9934 since there are lot of terms in common that should be going to **loris.pot and loris.po ** in place of my_preferences locale

racostas

Hi @SKADE2303, it seems you forgot to update you code when the translations were moved to loris ns

Again, please manual test before sent the PR ready to be reviewed.
@christinerogers , @driusan

racostas

Good advances, some minor changes. Please address. Thanks.

racostas · 2025-10-28T13:36:48Z

php/libraries/Password.class.inc

-                    'This password is known to be exposed in online data '
-                    . 'breaches.'
+                    dgettext(
+                        'loris',
+                        'This password is known to be exposed in online data'
+                        . 'breaches.'
+                    )


As in #9934 you need to leave the space after "data" if not this will not match the key in the loris.po file

racostas · 2025-10-28T14:03:13Z

All related email_text translations seems to be coming from database, please don't translate in this PR. Also don't seems to be working the way proposed in the PR.

racostas

Please note that Email address is now on loris.po while is was not updated in the code side.

This is causing this translation not been shown.

racostas

Kudos !!

Looking good to me.
I left you the final review @driusan

@christinerogers, @driusan

driusan · 2025-10-29T20:14:34Z

locale/loris.pot

 msgid "Site"
 msgstr ""

-msgid "Module"


Why is "Module" being removed from the template here?

@SKADE2303 , yes this is a bug. Please fix, since the template (.pot file) is what we use to translate to other languages.

Thanks @driusan for catching this one.

Add Translation

b1c886a

SKADE2303 added Module: my_preferences PR or issue related to my_preferences module Event: GSOC PR or issue accepted for Google Summer of Code Multilingual Any tasks related to making LORIS multilingual labels Sep 15, 2025

SKADE2303 requested a review from racostas September 15, 2025 14:04

racostas self-assigned this Sep 15, 2025

racostas requested changes Sep 16, 2025

View reviewed changes

racostas added the State: Needs work PR awaiting additional work by the author to proceed label Sep 16, 2025

racostas assigned SKADE2303 Sep 16, 2025

move translations

2cdf78a

github-actions bot added the Language: PHP PR or issue that update PHP code label Sep 19, 2025

additional translations

41d56c4

SKADE2303 force-pushed the TranslateMyPreferences branch from 2509634 to 41d56c4 Compare September 19, 2025 12:10

lint

5d670ed

racostas added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Sep 29, 2025

lint

c0e0aa5

SKADE2303 force-pushed the TranslateMyPreferences branch from 49c7b3a to c0e0aa5 Compare September 29, 2025 11:14

driusan mentioned this pull request Sep 29, 2025

[Core] Add Support for TOTP / 2FA to LORIS #9972

Merged

racostas self-requested a review September 30, 2025 14:56

racostas requested changes Sep 30, 2025

View reviewed changes

kongtiaowang closed this Sep 30, 2025

kongtiaowang reopened this Sep 30, 2025

lint

f01c570

SKADE2303 force-pushed the TranslateMyPreferences branch 3 times, most recently from 0e4263c to 5a04f4f Compare October 1, 2025 14:01

racostas requested changes Oct 23, 2025

View reviewed changes

racostas reviewed Oct 23, 2025

View reviewed changes

racostas mentioned this pull request Oct 23, 2025

[user_accounts] Translate user_accounts module #9934

Closed

SKADE2303 force-pushed the TranslateMyPreferences branch 2 times, most recently from 4d433af to 92257be Compare October 26, 2025 13:51

racostas requested changes Oct 27, 2025

View reviewed changes

SKADE2303 removed the State: Blocking PR should be prioritized because it is blocking the progress of another task label Oct 27, 2025

SKADE2303 force-pushed the TranslateMyPreferences branch 2 times, most recently from 8e38734 to 0dade10 Compare October 27, 2025 16:27

SKADE2303 removed the State: Needs work PR awaiting additional work by the author to proceed label Oct 27, 2025

racostas requested changes Oct 28, 2025

View reviewed changes

racostas added the State: Needs work PR awaiting additional work by the author to proceed label Oct 28, 2025

SKADE2303 force-pushed the TranslateMyPreferences branch from a3129ff to d33aa8c Compare October 28, 2025 16:36

SKADE2303 removed the State: Needs work PR awaiting additional work by the author to proceed label Oct 28, 2025

racostas requested changes Oct 29, 2025

View reviewed changes

racostas added the State: Needs work PR awaiting additional work by the author to proceed label Oct 29, 2025

fixes2

df10d8b

SKADE2303 force-pushed the TranslateMyPreferences branch from c371ef2 to df10d8b Compare October 29, 2025 15:32

Merge branch 'main' into TranslateMyPreferences

3f55e58

racostas self-requested a review October 29, 2025 19:59

racostas approved these changes Oct 29, 2025

View reviewed changes

racostas added Passed manual tests PR has been successfully tested by at least one peer and removed State: Needs work PR awaiting additional work by the author to proceed labels Oct 29, 2025

driusan reviewed Oct 29, 2025

View reviewed changes

racostas added the State: Needs work PR awaiting additional work by the author to proceed label Oct 29, 2025

Add Module String

6c63c90

driusan merged commit 38d48cd into aces:main Oct 30, 2025
20 checks passed

[my_preferences] Translate to my_preferences module #10015

[my_preferences] Translate to my_preferences module #10015

Uh oh!

Conversation

SKADE2303 commented Sep 15, 2025

Uh oh!

racostas left a comment

Choose a reason for hiding this comment

Uh oh!

racostas commented Sep 16, 2025

Uh oh!

racostas commented Sep 23, 2025

Uh oh!

racostas commented Sep 29, 2025

Uh oh!

racostas commented Sep 30, 2025

Uh oh!

racostas left a comment

Choose a reason for hiding this comment

Uh oh!

racostas left a comment

Choose a reason for hiding this comment

Uh oh!

racostas commented Oct 23, 2025

Uh oh!

racostas Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

racostas commented Oct 23, 2025

Uh oh!

racostas left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

racostas left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

racostas Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

racostas commented Oct 28, 2025

Uh oh!

racostas left a comment

Choose a reason for hiding this comment

Uh oh!

racostas left a comment

Choose a reason for hiding this comment

Uh oh!

driusan Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

racostas Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

racostas left a comment •

edited

Loading

racostas left a comment •

edited

Loading