Make 'ws' feature of actix-http optional in actix-web#3734
Merged
robjtede merged 7 commits intoactix:masterfrom Aug 29, 2025
Merged
Make 'ws' feature of actix-http optional in actix-web#3734robjtede merged 7 commits intoactix:masterfrom
robjtede merged 7 commits intoactix:masterfrom
Conversation
Porges
changed the title
robjtede
approved these changes
Aug 29, 2025
Contributor
Author
|
@robjtede any chance of a release which includes this? |
Member
|
@Porges Hey, sorry for the delay! I'm going to cut a new release once a remaining thing is resolved, hopefully in this weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Other
PR Checklist
Tests for the changes have been added / updated.Documentation comments have been added / updated.Overview
Allows users to opt-out of the
wsfeature ofactix-httpwhen depending onactix-web. This allows pruning of packages which are unused or might cause problems in some cases.→ In my case, the
sha1package may not be depended upon and triggers static analysis failures when it shows up inCargo.lock.default-features = falseis used and websocket support is required then this is a (build) breaking change.actix-web-actorsis?