Skip to content

refactor: GainMatrixUpdater uses AnyMutableTrackState #4890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 12 commits into from
Jan 20, 2026
Merged

refactor: GainMatrixUpdater uses AnyMutableTrackState #4890

kodiakhq merged 12 commits into from
Jan 20, 2026
+162 −260

Conversation

@paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Dec 9, 2025 •
edited
Loading

@paulgessinger paulgessinger changed the title refactor: Extend the track proxy concept refactor: GainMatrixUpdater uses AnyMutableTrackState Dec 9, 2025
@github-actions github-actions bot added this to the next milestone Dec 9, 2025
@paulgessinger paulgessinger added the 🛑 blocked This item is blocked by another item label Dec 10, 2025
@paulgessinger paulgessinger force-pushed the refactor/gmu-any-track-state branch from 417fe65 to 87c35e1 Compare December 10, 2025 11:47
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 10, 2025

Quality Gate Passed Quality Gate passed

Issues
48 New issues
0 Accepted issues

Measures
0 Security Hotspots
49.5% Coverage on New Code
5.5% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025 •
edited
Loading

📊: Physics performance monitoring for 97c1dda

Full contents

physmon summary

@andiwand andiwand mentioned this pull request Dec 12, 2025
Merged
@paulgessinger paulgessinger force-pushed the refactor/gmu-any-track-state branch from 87c35e1 to f3dda0a Compare January 9, 2026 16:19
@paulgessinger paulgessinger removed the 🛑 blocked This item is blocked by another item label Jan 9, 2026
@paulgessinger paulgessinger force-pushed the refactor/gmu-any-track-state branch 2 times, most recently from e9ad869 to 3c71a50 Compare January 14, 2026 09:59
@andiwand
Copy link
Contributor

andiwand commented Jan 15, 2026

I do not observe a meaningful performance impact
image
image

andiwand
andiwand previously approved these changes Jan 15, 2026
View reviewed changes
@paulgessinger paulgessinger marked this pull request as ready for review January 16, 2026 16:03
@paulgessinger paulgessinger force-pushed the refactor/gmu-any-track-state branch from 837b621 to 7056b32 Compare January 16, 2026 16:03
@acts-policybot acts-policybot bot dismissed andiwand’s stale review January 16, 2026 16:03

Invalidated by push of 7056b32

@paulgessinger
Copy link
Member Author

paulgessinger commented Jan 19, 2026

@andiwand do you think we should go ahead with this one?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 20, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
39.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kodiakhq kodiakhq bot merged commit 78ac17d into acts-project:main Jan 20, 2026
43 checks passed
@acts-project-service
Copy link
Collaborator

acts-project-service commented Jan 20, 2026

🔴 Athena integration test results [78ac17d]

🔴 Some tests have failed!

Please investigate the pipeline!

status job report
🟢 report_pull_request
🔴 run_workflow_tests_run4_mc
🔴 run_workflow_tests_run2_mc
🔴 run_workflow_tests_run2_data
🔴 run_workflow_tests_run3_mc
🟡 run_workflow_tests_run3_data
🟢 test_ActsPersistifyEDM
🟢 test_ActsDumpGeometryIdentifiers
🔴 test_ActsCheckObjectCountsWorkflowHgtd
🔴 test_ActsCheckObjectCountsCachedWorkflow
🔴 test_ActsCheckObjectCountsLegacyWorkflow
🔴 test_ActsCheckObjectCountsWorkflow
🟢 test_ActsEFTrackFit
🟢 test_ActsPersistifySeeds
🟢 test_ActsBenchmarkWithSpot
🟢 test_ActsAnalogueClustering
🟢 test_ActsWorkflowHeavyIons
🟢 test_ActsWorkflowFastTracking
🔴 test_ActsWorkflowCached
🔴 test_ActsWorkflow
🟢 test_ActsValidateAmbiguityResolution
🟢 test_ActsValidateResolvedTracks
🟢 test_ActsValidateTracks
🟢 test_ActsValidateActsCoreSpacePoints
🟢 test_ActsValidateActsSpacePoints
🟢 test_ActsValidateSeeds
🟢 test_ActsValidateOrthogonalSeeds
🟢 test_ActsValidateClusters
🟢 test_ActsGx2fRefitting
🟢 test_ActsGSFRefitting
🔴 test_ActsKfRefitting
🟢 test_ActsExtrapolationAlgTest
🟢 test_ActsITkTest

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andiwand andiwand andiwand approved these changes

Assignees

No one assigned

Labels

Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests Track Fitting

Projects

None yet

Milestone

next

Development

Successfully merging this pull request may close these issues.

3 participants

@paulgessinger @andiwand @acts-project-service