Skip to content

Conversation

@tsulaiav
Copy link
Contributor

For the time being, this example only demonstrates how to use multiple detray detector views from the traccc code. Several other improvements should be made to the code. For instance, multiple contexts are ignored in the CPU-based fitting.

That's why the PR is marked as draft for the time being.

@tsulaiav tsulaiav force-pushed the main-misalignedfitting-cuda-ex branch from ce25646 to a7bcae8 Compare June 27, 2025 23:47
@tsulaiav tsulaiav force-pushed the main-misalignedfitting-cuda-ex branch from a7bcae8 to b25e13e Compare July 17, 2025 00:18
@tsulaiav tsulaiav marked this pull request as ready for review July 17, 2025 00:19
@sonarqubecloud
Copy link

Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to rather than introducing a new executable, add misalignment as a new option to the existing traccc_truth_fitting_esample_cuda executable? 🤔

I started playing a little while ago with merging the example applications of all the languages into a single codebase, but did not find a good design for that yet. 😦 Still, cutting down a bit on the number of executables could be helpful for that effort as well.

@tsulaiav
Copy link
Contributor Author

Would it make sense to rather than introducing a new executable, add misalignment as a new option to the existing traccc_truth_fitting_esample_cuda executable? 🤔

I started playing a little while ago with merging the example applications of all the languages into a single codebase, but did not find a good design for that yet. 😦 Still, cutting down a bit on the number of executables could be helpful for that effort as well.

I'm with you on this. I will see over the next days if/how this can be merged with truth_fitting_example_cuda.cpp. By the way, the same should be done for the similar CPU-based example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants