Skip to content

Minor improvements#47

Open
aremmell wants to merge 4 commits intoadafruit:masterfrom
aremmell:master
Open

Minor improvements#47
aremmell wants to merge 4 commits intoadafruit:masterfrom
aremmell:master

Conversation

@aremmell
Copy link

  • Delete default constructor, so that people don't accidentally default-construct an instance which will have garbage values for all members (including CS and RST pins)
  • Implement virtual destructor (derived class). Actually, now that I think about it, Adafruit_GFX needs a virtual destructor as well. I'll submit a different PR for that
  • Provide default initialization values for members which will remain uninitialized with garbage values until begin() is called (I found out the hard way when I tried to get width and height before calling begin())
  • Remove unnecessary if-statement (an unsigned 8-bit value cannot be greater than 255, so the capping is superfluous)

@aremmell
Copy link
Author

aremmell commented Dec 5, 2025

Hi. Are these repositories in need of additional maintainers? I have 30 years' experience, and I volunteer to assist. I think that additional maintainers may be needed sooner than later with the Qualcomm acquisition and unknown status of Arduino already here. Let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant