Skip to content

Minor improvements #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aremmell wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Minor improvements #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2658a30
initial default values for members (begin() to assign actual values)
aremmell Dec 13, 2023
88c22a6
remove dead code (uin8_t cannot be greater than 255)
aremmell Dec 13, 2023
31b0eb4
delete default constructor to avoid accidental invalid construction
aremmell Dec 13, 2023
eb67879
implement virtual destructor
aremmell Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Adafruit_RA8875.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ static inline void spi_end(void) { SPI.endTransaction(); }
*/
/**************************************************************************/
Adafruit_RA8875::Adafruit_RA8875(uint8_t CS, uint8_t RST)
: Adafruit_GFX(800, 480) {
: Adafruit_GFX(800, 480), _width(0), _height(0), _textScale(1),
_rotation(1), _voffset(0) {
_cs = CS;
_rst = RST;
}
Expand Down Expand Up @@ -502,8 +503,6 @@ void Adafruit_RA8875::cursorBlink(uint8_t rate) {
temp |= RA8875_MWCR0_BLINK;
writeData(temp);

if (rate > 255)
rate = 255;
writeCommand(RA8875_BTCR);
writeData(rate);
}
Expand Down
2 changes: 2 additions & 0 deletions Adafruit_RA8875.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,9 @@ typedef struct // Matrix
/**************************************************************************/
class Adafruit_RA8875 : public Adafruit_GFX {
public:
Adafruit_RA8875() = delete;
Adafruit_RA8875(uint8_t cs, uint8_t rst);
virtual ~Adafruit_RA8875() = default;

boolean begin(enum RA8875sizes s);
void softReset(void);
Expand Down