Enable use of pins >32 on RP2350B #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…overflow Fix pre-encoded data buffer overflow
…path and buffer overflow check.
Fix hang on disconnect of non-compliant devices: Added timeout to RX …
dhalbert
approved these changes
Dec 27, 2024
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
LGTM but the proof is in the testing, as you did.
tannewt
added a commit
that referenced
this pull request
Apr 1, 2025
fix rp2040 critical timing when sending handshake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fails CI (because it tests old SDK versions and we only use sdk 2.1.0) but pinky swear, it works for me :)Merged upstream & fixed old SDK version support & added CI for sdk 2.1.0
Also PR'd upstream: sekigon-gonnoc#157