refactor(csharp): consolidate CloudFetch memory buffer default to single source of truth#294
Merged
eric-wang-1990 merged 2 commits intomainfrom Mar 5, 2026
Conversation
CloudFetchMemoryBufferManager defaults to 200MB when no value is provided, but CloudFetchConfiguration defaulted to 100MB. The factory always passes config.MemoryBufferSizeMB to the manager, so the effective default was 100MB — inconsistent with the manager's own constant. Aligns both to 200MB so the defaults agree regardless of how CloudFetchMemoryBufferManager is instantiated. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
eric-wang-1990
had a problem deploying
to
azure-prod
GitHub Actions
Error
…iguration Remove duplicate DefaultMemoryBufferSizeMB constant from CloudFetchMemoryBufferManager and reference CloudFetchConfiguration.DefaultMemoryBufferSizeMB as the single source of truth. Also simplify constructor from nullable int? to int with default parameter. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
eric-wang-1990
requested a deployment
to
azure-prod
GitHub Actions
Waiting
eric-wang-1990
changed the title
jadewang-db
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CloudFetchConfigurationdefaulted to 100MB whileCloudFetchMemoryBufferManagerhad its own duplicate constant defaulting to 200MBconfig.MemoryBufferSizeMBto the manager, making the manager's private constant dead code in production — but the two definitions could silently drift apartCloudFetchConfiguration.DefaultMemoryBufferSizeMBto 200MB (matching the manager's original intent)DefaultMemoryBufferSizeMBconstant fromCloudFetchMemoryBufferManagerand replaces it with a reference toCloudFetchConfiguration.DefaultMemoryBufferSizeMBint? maxMemoryMB = nulltoint maxMemoryMB = CloudFetchConfiguration.DefaultMemoryBufferSizeMBCloudFetchConfiguration.DefaultMemoryBufferSizeMBinstead of a magic numberTest plan
CloudFetchMemoryBufferManagerTestspass unchangedconfig.MemoryBufferSizeMBexplicitly and are unaffected🤖 Generated with Claude Code