Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion csharp/src/Reader/CloudFetch/CloudFetchConfiguration.cs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ internal sealed class CloudFetchConfiguration
// Default values
internal const int DefaultParallelDownloads = 3;
internal const int DefaultPrefetchCount = 2;
internal const int DefaultMemoryBufferSizeMB = 100;
internal const int DefaultMemoryBufferSizeMB = 200;
internal const int DefaultTimeoutMinutes = 5;
internal const int DefaultMaxRetries = 3;
internal const int DefaultRetryDelayMs = 500;
Expand Down
8 changes: 3 additions & 5 deletions csharp/src/Reader/CloudFetch/CloudFetchMemoryBufferManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ namespace AdbcDrivers.Databricks.Reader.CloudFetch
/// </summary>
internal sealed class CloudFetchMemoryBufferManager : ICloudFetchMemoryBufferManager
{
private const int DefaultMemoryBufferSizeMB = 200;
private readonly long _maxMemory;
private long _usedMemory;
private readonly SemaphoreSlim _memorySemaphore;
Expand All @@ -48,16 +47,15 @@ internal sealed class CloudFetchMemoryBufferManager : ICloudFetchMemoryBufferMan
/// Initializes a new instance of the <see cref="CloudFetchMemoryBufferManager"/> class.
/// </summary>
/// <param name="maxMemoryMB">The maximum memory allowed for buffering in megabytes.</param>
public CloudFetchMemoryBufferManager(int? maxMemoryMB = null)
public CloudFetchMemoryBufferManager(int maxMemoryMB = CloudFetchConfiguration.DefaultMemoryBufferSizeMB)
{
int memoryMB = maxMemoryMB ?? DefaultMemoryBufferSizeMB;
if (memoryMB <= 0)
if (maxMemoryMB <= 0)
{
throw new ArgumentOutOfRangeException(nameof(maxMemoryMB), "Memory buffer size must be positive.");
}

// Convert MB to bytes
_maxMemory = memoryMB * 1024L * 1024L;
_maxMemory = maxMemoryMB * 1024L * 1024L;
_usedMemory = 0;
_memorySemaphore = new SemaphoreSlim(1, 1);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public class CloudFetchMemoryBufferManagerTests
public void Constructor_DefaultMaxMemory_Is200MB()
{
var manager = new CloudFetchMemoryBufferManager();
Assert.Equal(200 * 1024L * 1024L, manager.MaxMemory);
Assert.Equal(CloudFetchConfiguration.DefaultMemoryBufferSizeMB * 1024L * 1024L, manager.MaxMemory);
Assert.Equal(0, manager.UsedMemory);
}

Expand Down
Loading