Added consent gating to the Advertising component to ensure no advertising cookies are written before user consent is resolved.#1442
Merged
carterworks merged 13 commits intomainfrom Feb 11, 2026
Conversation
updated the skipped tests for helper.js in componentRegistered hook , for viewthru : return promise for click thru advertising call , for viewthru case fire and forget Add timestamp in payload of enrichment calls
Move LAST_CLICK_COOKIE_KEY cookie write from clickThroughHandler into createAdConversionHandler.trackAdConversion(), after consent.awaitConsent() resolves. This ensures no ad-tracking cookies (skwcid/efid) are set without user consent. Changes: - clickThroughHandler: removed pre-consent LAST_CLICK_COOKIE_KEY write, pass skwcid/efid through to trackAdConversion() - createAdConversionHandler: accept cookieManager, write click cookie only after consent is granted - index.js: pass cookieManager to createAdConversionHandler (1-line change)
🦋 Changeset detectedLatest commit: ab0b821 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
carterworks
requested changes
Feb 10, 2026
Collaborator
carterworks
left a comment
carterworks
left a comment
There was a problem hiding this comment.
- In your CLI, please run
pnpm changeset, select the@adobe/alloypackage, and write what you want to go into the release notes. - Please write a new PR description - what you wrote in this one seems like a copy-paste of #1435 and I don't know what the motivation or details for this issue are.
Contributor
Author
Updated description and added pnpm note |
carterworks
changed the title
carterworks
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
createComponent.js—synchronousconsent.current()check ononBeforeEventto skip ad ID resolution when consent is not "in"index.js— pass consent dependency through tocreateComponentRelated Issue
Pre-consent cookie writes in the Advertising component.
Motivation and Context
Dont resolve ad ids on sendEvent commands
Checklist: