Skip to content

fixed clickthrough handling for duplicate s_kwcid/ef_id query params#1443

Merged
carterworks merged 4 commits intomainfrom
fix-s_kwcid-error
Feb 11, 2026
Merged

fixed clickthrough handling for duplicate s_kwcid/ef_id query params#1443
carterworks merged 4 commits intomainfrom
fix-s_kwcid-error

Conversation

@carterworks
Copy link
Collaborator

@carterworks carterworks commented Feb 10, 2026

Description

  • added regression coverage for malformed URLs with duplicate s_kwcid values at both unit and integration levels.
  • normalized clickthrough query params so handleClickThrough safely handles string | string[] and uses the first value when duplicates are present.
  • updated release metadata with a patch changeset for this consumer-facing bug fix.

Related Issue

Motivation and Context

Malformed URLs can contain duplicate query params. queryString.parse may return arrays in that case, which caused skwcid.startsWith to throw and prevented clickthrough conversion tracking. This change prevents runtime errors and preserves conversion tracking by coercing duplicate values to the first entry.

Screenshots (if appropriate):

N/A

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.
  • I have added a Changeset (pnpm changeset) or it is not necessary because this PR is not consumer-facing.

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2026

🦋 Changeset detected

Latest commit: 6bbbda3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@carterworks carterworks merged commit 5e5b811 into main Feb 11, 2026
5 of 6 checks passed
@carterworks carterworks deleted the fix-s_kwcid-error branch February 11, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error Handling Issue: startsWith Called on Array When Multiple s_kwcid Query Parameters Present

2 participants