[test] Testing PR 5222 - Test circleci migration #5280
Conversation
|
caseyisonit
changed the base branch from
main
to
chore-migrate-lint-github-from-circleci
castastrophe
changed the base branch from
chore-migrate-lint-github-from-circleci
to
main
castastrophe
force-pushed
the
main
branch
2 times, most recently
from
a890b72 to
9c6ef10
Compare
castastrophe
force-pushed
the
test-circleci-migration
branch
from
210e95f to
ff68bb1
Compare
| ref: ${{ inputs.ref || github.head_ref }} | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Setup Job and Install Dependencies |
There was a problem hiding this comment.
@castastrophe this job includes build do we need in the next step?
| run: yarn build | ||
|
|
||
| # This step will evaluate the repo status and report the change | ||
| # If there are changes, capture the changes and upload them as an artifact |
There was a problem hiding this comment.
Im not seeing an artifact upload and in CI I looks like this hangs after exit 1
| fetch-depth: 2 | ||
|
|
||
| - name: Setup Job and Install Dependencies | ||
| uses: ./.github/actions/setup-job |
There was a problem hiding this comment.
this includes a build step. we might consider removing it from the setup and make jobs run build explicitly
| cache: 'yarn' | ||
| registry-url: 'https://registry.npmjs.org' | ||
|
|
||
| ## --- YARN CACHE --- ## |
There was a problem hiding this comment.
would like to know more about this job and if we can leverage it for other jobs if its pulling a cache like I think it is. could improve our run time ten-fold
Description
Related issue(s)
Motivation and context
How has this been tested?
Test case 1
Test case 2
Did it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.