Skip to content

Conversation

@rubencarvalho
Copy link
Contributor

@rubencarvalho rubencarvalho commented Dec 11, 2025

Description

The size property from SizedMixin wasn't being recognized by storybook-helpers because the CEM was missing the shared base modules. Added ../core/shared/**/*.ts to cem.config.js globs and enabled size controls in all affected component stories 👍

Motivation and context

Without this we don't get the fancy select dropdown picker (just a textfield input 🤷 ).

Screenshots (if appropriate)

Screenshot 2025-12-12 at 14 09 37

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Verify it works

    1. Go to the deployed 2nd-gen Storybook
    2. Select a size from the select picker
    3. The component preview reacts to it!

@changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2025

⚠️ No Changeset found

Latest commit: 0088577

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rubencarvalho rubencarvalho marked this pull request as ready for review December 11, 2025 16:08
@rubencarvalho rubencarvalho requested a review from a team as a code owner December 11, 2025 16:08
@github-actions
Copy link
Contributor

📚 Branch Preview Links

🔍 First Generation Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5933

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link
Contributor

@caseyisonit caseyisonit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stealing this for my garage week branch

@rubencarvalho rubencarvalho merged commit f2837cf into main Dec 23, 2025
21 of 23 checks passed
@rubencarvalho rubencarvalho deleted the ruben/fix-size-controls-2nd-gen-storybook branch December 23, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants