Skip to content

chore: enable size controls for 2nd-gen components #5933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubencarvalho merged 1 commit into from
Dec 23, 2025
Merged

chore: enable size controls for 2nd-gen components #5933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion 2nd-gen/packages/swc/cem.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@
*/

export default {
globs: ['components/**/*.ts', '../core/components/**/*.ts'],
globs: [
'components/**/*.ts',
'../core/components/**/*.ts',
'../core/shared/**/*.ts',
],
exclude: ['**/*.stories.ts', '**/*.test.ts', '**/*.spec.ts'],
outdir: '.storybook',
litelement: true,
Expand Down
15 changes: 5 additions & 10 deletions 2nd-gen/packages/swc/components/badge/stories/badge.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,11 @@ argTypes.fixed = {
options: [undefined, ...Badge.FIXED_VALUES],
};

/*
* @todo This is properly configuring the Select, but the control doesn't
* seem to work; need to investigate.
*/

// argTypes.size = {
// ...argTypes.size,
// control: { type: 'select' },
// options: Badge.VALID_SIZES,
// };
argTypes.size = {
...argTypes.size,
control: { type: 'select' },
options: Badge.VALID_SIZES,
};

args['default-slot'] = 'Badge';

Expand Down
15 changes: 5 additions & 10 deletions 2nd-gen/packages/swc/components/divider/stories/divider.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,11 @@ import '@adobe/swc/divider';

const { events, args, argTypes, template } = getStorybookHelpers('swc-divider');

/*
* @todo This is properly configuring the Select, but the control doesn't
* seem to work; need to investigate.
*/

// argTypes.size = {
// ...argTypes.size,
// control: { type: 'select' },
// options: Divider.VALID_SIZES,
// };
argTypes.size = {
...argTypes.size,
control: { type: 'select' },
options: Divider.VALID_SIZES,
};

argTypes['static-color'] = {
...argTypes['static-color'],
Expand Down
14 changes: 5 additions & 9 deletions 2nd-gen/packages/swc/components/progress-circle/stories/progress-circle.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,11 @@ const { events, args, argTypes, template } = getStorybookHelpers(
// control: { type: 'range', min: 0, max: 100, step: 1 },
// };

/*
* @todo This is properly configuring the Select, but the control doesn't
* seem to work; need to investigate.
*/
// argTypes.size = {
// ...argTypes.size,
// control: { type: 'select' },
// options: ProgressCircle.VALID_SIZES,
// };
argTypes.size = {
...argTypes.size,
control: { type: 'select' },
options: ProgressCircle.VALID_SIZES,
};

argTypes['static-color'] = {
...argTypes['static-color'],
Expand Down
22 changes: 5 additions & 17 deletions 2nd-gen/packages/swc/components/status-light/stories/status-light.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,23 +30,11 @@ argTypes.variant = {
options: StatusLight.VARIANTS,
};

/*
* @todo This is properly configuring the Select, but the control doesn't
* seem to work; need to investigate.
*
* We may have to explicitly bind the args to the component (particularly
* helpful for the size property) so the Storybook controls work as expected.
*
* i.e. render: (args) =>
html`<swc-status-light .size=${args.size} variant=${args.variant}
>${args['default-slot']}</swc-status-light
>`,
*/
// argTypes.size = {
// ...argTypes.size,
// control: { type: 'select' },
// options: StatusLight.VALID_SIZES,
// };
argTypes.size = {
...argTypes.size,
control: { type: 'select' },
options: StatusLight.VALID_SIZES,
};

args['default-slot'] = 'Status light';
args.size = 'm';
Expand Down
Loading