[Issue 6653] reenabling of testHeadlessComponents test #6777
Conversation
change target test branch
download submodules for the repo
andrlos
changed the title
| </disables> | ||
| <command> | ||
| export OJDK_VERSION_NUMBER=$(JDK_VERSION) JREJDK="jdk" TMPRESULTS=$(Q)$(REPORTDIR)$(D)report$(Q); \ | ||
| $(JAVA_TO_TEST) -version; \ |
There was a problem hiding this comment.
I am on the fence about leaving this in for future debug purposes or just ditching it.
There was a problem hiding this comment.
We print java information and all environment variables out at the start of each Jenkins job run, so I vote ditch to avoid duplication.
karianna
left a comment
karianna
left a comment
There was a problem hiding this comment.
Code change looks good.
| <comment>https://github.com/adoptium/aqa-tests/issues/5224</comment> | ||
| <impl>ibm</impl> | ||
| </disable> | ||
| <disable> |
There was a problem hiding this comment.
Can we enable <impl>hotspot</impl> only before it's been verified by other vendor?
There was a problem hiding this comment.
I mean.. sure, but.. can't we verify the changes in bulk with all the vendors and get a matrix of where it passes/fails? I either lack the priviledges or knowledge to do it myself, but it would seem like the most sensible way of doing it, since the test runs for approximately 10 minutes at most. But sure, hotspot only is a viable route to take..
smlambert
left a comment
smlambert
left a comment
There was a problem hiding this comment.
From #6653 (comment)
I can continue testing manually individually but I believe there is probably a nicer way to test this and be thorough
Reviewers will run an AQA_Test_Pipeline as a final part of the review process, before bringing these changes in.
|
For reference, I believe the actual changes to TestHeadlessComponents to be accepted into AQA were done via: rh-openjdk/TestHeadlessComponents#13 @andrlos Were there any other changes that are relevant? This is helpful in case a reviewer wants to inspect those as well. |
|
@jiekang you are right, that is the changeset.. no - there are no other relevant changes... and I thought, that I already linked it somewhere either here or in the issue, sorry |
|
@andrlos Could you take a look at the new comments added? |
|
@sophia-guo you mean the one about the hotspot? I thought.. nevermind, will write it as a reply to the comment :-) |
|
@sophia-guo , I disabled ibm and openj9 |
|
Grinder https://ci.adoptium.net/view/Test_grinder/job/Grinder/15741/ - waiting |
6 participants
TestHeadless components was re-done to reflect issues raised in the #6653