Skip to content

[Issue 6653] reenabling of testHeadlessComponents test #6777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sophia-guo merged 11 commits into from
Dec 11, 2025
Merged

[Issue 6653] reenabling of testHeadlessComponents test #6777

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b04dbca
update playlist to use the JAVA_TO_TEST variable for testing
andrlos Nov 5, 2025
3ee66a3
Update build.xml to use the JAVA_TO_TEST variable for testing
andrlos Nov 5, 2025
c738dba
Merge branch 'adoptium:master' into testNewJRE
andrlos Nov 7, 2025
0858f30
Update build.xml
andrlos Nov 7, 2025
16c8964
Update build.xml
andrlos Nov 10, 2025
5ec17a8
Merge branch 'adoptium:master' into testNewJRE
andrlos Nov 19, 2025
61b4aee
special branch no longer needed, as changes were merged to master
jandrlik Dec 5, 2025
639ab06
forgot about usage of USE_JRE to figure out whether we test jre or jdk
jandrlik Dec 5, 2025
49f0518
wrong escaping of USE_JRE
jandrlik Dec 5, 2025
d3f6084
ditching the JAVA_TO_TEST version
jandrlik Dec 9, 2025
37d27a1
disabling openj9 and ibm vendor and leaving only hotspot for now
jandrlik Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions functional/testHeadlessComponents/build.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
<exec executable="git" failonerror="true">
<arg value="clone" />
<arg value="${GIT_REPO}rh-openjdk/TestHeadlessComponents.git" />
<arg value="--recurse-submodules"/>
</exec>
</target>

Expand Down
37 changes: 3 additions & 34 deletions functional/testHeadlessComponents/playlist.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,41 +15,10 @@
<playlist xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../TKG/resources/playlist.xsd">
<test>
<testCaseName>TestHeadlessComponents</testCaseName>
<disables>
<disable>
<comment>https://github.com/adoptium/aqa-tests/issues/5224</comment>
<impl>openj9</impl>
</disable>
<disable>
<comment>https://github.com/adoptium/aqa-tests/issues/5224</comment>
<impl>ibm</impl>
</disable>
<disable>
Copy link
Contributor

@sophia-guo sophia-guo Dec 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we enable <impl>hotspot</impl> only before it's been verified by other vendor?

Copy link
Contributor Author

@andrlos andrlos Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean.. sure, but.. can't we verify the changes in bulk with all the vendors and get a matrix of where it passes/fails? I either lack the priviledges or knowledge to do it myself, but it would seem like the most sensible way of doing it, since the test runs for approximately 10 minutes at most. But sure, hotspot only is a viable route to take..

<comment>https://github.com/adoptium/aqa-tests/issues/6647#issuecomment-3382932623</comment>
<platform>aarch64_mac</platform>
<impl>hotspot</impl>
</disable>
<disable>
<comment>https://github.com/adoptium/aqa-tests/pull/6648#issuecomment-3397002761</comment>
<platform>x86-64_windows</platform>
<impl>hotspot</impl>
<version>8</version>
</disable>
<disable>
<comment>https://github.com/adoptium/aqa-tests/issues/5775</comment>
<platform>x86-64_mac</platform>
<impl>hotspot</impl>
<version>8</version>
</disable>
<disable>
<comment>https://github.com/adoptium/aqa-tests/pull/6616#issuecomment-3323705754</comment>
<platform>x86-64_mac</platform>
<impl>hotspot</impl>
<version>25</version>
</disable>
</disables>
<command>
export OJDK_VERSION_NUMBER=$(JDK_VERSION) JREJDK="jdk" TMPRESULTS=$(Q)$(REPORTDIR)$(D)report$(Q); \
$(JAVA_TO_TEST) -version; \
Copy link
Contributor Author

@andrlos andrlos Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am on the fence about leaving this in for future debug purposes or just ditching it.

Copy link
Contributor

@smlambert smlambert Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We print java information and all environment variables out at the start of each Jenkins job run, so I vote ditch to avoid duplication.

case "$(USE_JRE)" in true) JREJDK=jre ;; *) JREJDK=jdk ;; esac; \
export JAVA_TO_TEST=$(JAVA_TO_TEST) OJDK_VERSION_NUMBER=$(JDK_VERSION) JREJDK TMPRESULTS=$(Q)$(REPORTDIR)$(D)report$(Q); \
bash $(TEST_ROOT)$(D)functional$(D)testHeadlessComponents$(D)TestHeadlessComponents$(D)testHeadlessComponents.sh; \
$(TEST_STATUS)
</command>
Expand Down