refactor: use types consistently instead of typings#130
Merged
Conversation
- since `typings` is now considered a legacy alias and can't be used inside of `exports`, update all references to consistently use `types` - `package.json#typings` -> `types` - `typings` folder -> `types` - for similar reasons, use consistent relative path `./` in `package.json` - so `types` matches `exports.types`, `main` matches `exports.require`, and `module` matches `exports.import` _exactly_
This comment was marked as resolved.
This comment was marked as resolved.
agilgur5
commented
Mar 27, 2025
This was referenced Mar 27, 2025
Closed
Hamza65523
pushed a commit
to Hamza65523/react-signature-canvas
that referenced
this pull request
Nov 2, 2025
- since `typings` is now considered a legacy alias and can't be used inside of `exports`, update all references to consistently use `types` - `package.json#typings` -> `types` - `typings` folder -> `types` - for similar reasons, use consistent relative path `./` in `package.json` - so `types` matches `exports.types`, `main` matches `exports.require`, and `module` matches `exports.import` _exactly_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename
typingsfields and directories totypesFollow-up to #126
Details
since
typingsis now considered a legacy alias and can't be used inside ofexports(as I discovered in fix(pkg): addtypestopackage.json#exports#126 (comment)), update all references to consistently usetypespackage.json#typings->typestypingsfolder ->typesfor similar reasons, use consistent relative path
./inpackage.jsontypesmatchesexports.types,mainmatchesexports.require, andmodulematchesexports.importexactly