Skip to content

fix(fileinput): fix a11y issue with a disconnect between the label and hidden input#567

Merged
stdavis merged 2 commits intomainfrom
fix/a11y-file-input
Dec 3, 2025
Merged

fix(fileinput): fix a11y issue with a disconnect between the label and hidden input#567
stdavis merged 2 commits intomainfrom
fix/a11y-file-input

Conversation

@stdavis
Copy link
Copy Markdown
Member

@stdavis stdavis commented Dec 2, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 2, 2025 21:48
@stdavis stdavis enabled auto-merge (rebase) December 2, 2025 21:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an accessibility issue by ensuring the Label component is properly associated with the hidden file input element generated by AriaFileTrigger. The fix wraps the entire file trigger component hierarchy in a Label element, establishing the necessary connection for assistive technologies.

Key Changes

  • Wraps the AriaFileTrigger and related components in a Label component to create proper label-input association
  • Refactors the label styling into a separate labelStyles TV configuration with required field indicator
  • Converts the label text to a <p> element to avoid nesting Label components

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 2, 2025

Visit the preview URL for this PR (updated for commit c4ca6a2):
Firebase Preview: https://ut-dts-agrc-kitchen-sink-dev--fix-a11y-file-input-hieshjiy.web.app
(expires "2025-12-16T21:58:29.445795137Z" )

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@steveoh steveoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stdavis stdavis merged commit 455071b into main Dec 3, 2025
13 checks passed
@stdavis stdavis deleted the fix/a11y-file-input branch December 3, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants