Open
Conversation
Missing 'return' so the code continued on and tried to parse garbage.
Note, SHA256 is not available on older NodeJS versions so we need to import a JS SHA256 library in a future commit Also this fails with mixed-mode ONVIF NVTs where the Authorizaition Header has multiple options eg 'Digest realm="PROXY", nonce="638987102484070019", algorithm=MD5, qop="auth", Digest realm="PROXY", nonce="638987102484070019", algorithm=SHA-256, qop="auth"' The Regex breaks with "cannot read properties of null (reading 'slice')
This is described in the ONVIF Spec and tested with a HikVision camera in MD5+AND_SHA256 mode
The try/catch for crypto.createHash would have had the sme result, but this makes the code clearer
Contributor
Author
|
Hello, there are some linting issues in the cam.js file. @ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the ONVIF specifications (https://www.onvif.org/onvif/ver20/ptz/wsdl/ptz.wsdl
)
The GetConfiguration response may include an optional Extensions element. This element can contain PTZ control direction options, such as Reverse and EFlip modes.
To do: add a getConfiguration(token) function to retrieve a specific PTZ configuration using its token.