-
Notifications
You must be signed in to change notification settings - Fork 15
Fix build #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix build #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The set-output step after the build fails due to #493
Contributor
Author
|
Oh shoot, downgrade didn't fix it??? hmm, turning to draft for now |
This reverts commit e4c5a5a.
fda292a to
3d2e4cd
Compare
Contributor
Author
|
This is ready to review (phew, so annoying), except for the Integration test failure due to ipywidgets upgrade, which should be solved by merging: aiidalab/aiidalab-widgets-base#721 |
This was referenced Dec 12, 2025
Contributor
Author
|
@yakutovicha I am going to merge this to unblock the other PRs, but happy to take questions or adjust in a follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The set-output step started failing again due to #493
This PR finally (hopefully) fixes #493. We'll first write the metadata output to a file, and then read in the JS script. Perhaps in the future there will be a better solution, see this request: docker/bake-action#178 (comment)