Skip to content

Conversation

@AraHaan
Copy link
Contributor

@AraHaan AraHaan commented Jan 8, 2026

What do these changes do?

This adds the Windows 11 arm64 runner image for github actions to the CI/CD workflow matrix to ensure that the win_arm64 wheel gets built. Without this I cannot use --platform that passes in win_arm64 into pip to install all of the packages in my requirements.txt which include discord.py, asqlite, and aiohttp. With this change there is a chance that aiohttp could get a win_arm64 wheel published to pypi just like with yarl and multidict to name a few binary packages that are dependencies of aiohttp.

Are there changes in behavior for the user?

No changes, other than allowing one to pip install aiohttp using it's --platform argument which forces install from wheels as the only valid option, without arm64 wheels it will try to install version 0.13.1 of aiohttp which is not supported in many packages (many packages supports aiohttp<4,>=3.7.4, only).

Is it a substantial burden for the maintainers to support this?

Nope, all this does is adds the new arm64 windows github actions runner to build the win_arm64 wheel for publish to pypi.

Related issue number

Fixes #11937

Checklist

  • I think the code is well written
  • Unit tests for the changes exist (I doubt unit tests are needed for a minor CI change)
  • Documentation reflects the changes (No doc changes are needed)
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt (No code changes are provided.)
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

The win_arm64 wheels were not getting built and published to pypi.

Fixes aio-libs#11937.
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 8, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing AraHaan:patch-1 (a86740d) with master (de258a1)

Summary

✅ 59 untouched benchmarks

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.75%. Comparing base (de258a1) to head (a86740d).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11938      +/-   ##
==========================================
+ Coverage   98.73%   98.75%   +0.02%     
==========================================
  Files         127      127              
  Lines       44581    44581              
  Branches     2358     2358              
==========================================
+ Hits        44019    44028       +9     
+ Misses        399      393       -6     
+ Partials      163      160       -3     
Flag Coverage Δ
CI-GHA 98.61% <ø> (+0.01%) ⬆️
OS-Linux 98.35% <ø> (+0.01%) ⬆️
OS-Windows 96.70% <ø> (ø)
OS-macOS 97.58% <ø> (-0.01%) ⬇️
Py-3.10.11 97.13% <ø> (+<0.01%) ⬆️
Py-3.10.19 97.62% <ø> (ø)
Py-3.11.14 97.82% <ø> (ø)
Py-3.11.9 97.34% <ø> (+<0.01%) ⬆️
Py-3.12.10 97.43% <ø> (ø)
Py-3.12.12 97.92% <ø> (ø)
Py-3.13.11 98.17% <ø> (+<0.01%) ⬆️
Py-3.14.2 98.14% <ø> (-0.01%) ⬇️
Py-3.14.2t 97.22% <ø> (-0.01%) ⬇️
Py-pypy3.11.13-7.3.20 97.38% <ø> (?)
VM-macos 97.58% <ø> (-0.01%) ⬇️
VM-ubuntu 98.35% <ø> (+0.01%) ⬆️
VM-windows 96.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AraHaan
Copy link
Contributor Author

AraHaan commented Jan 8, 2026

More changes might be needed in the workflow file to add aiohttp-*-win_arm64.whl to the list of files here: https://pypi.org/project/aiohttp/#files

@webknjaz
Copy link
Member

This is probably enough for now. Just a change note's needed. In the future, it'd be good to replicate the approach with reusable workflows from multidict/yarl/etc.

@webknjaz webknjaz requested a review from bdraco January 11, 2026 09:39
Added win_arm64 to the wheels that gets pushed to PyPI
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 11, 2026
@Dreamsorcerer Dreamsorcerer added the backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot label Jan 11, 2026
@AraHaan AraHaan marked this pull request as ready for review January 11, 2026 23:52
@Dreamsorcerer Dreamsorcerer merged commit d09103a into aio-libs:master Jan 12, 2026
67 of 73 checks passed
@patchback
Copy link
Contributor

patchback bot commented Jan 12, 2026

Backport to 3.14: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.14/d09103a5baed801a0d475a79270cc08b205110bb/pr-11938

Backported as #11958

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 12, 2026
@AraHaan AraHaan deleted the patch-1 branch January 12, 2026 14:41
Dreamsorcerer pushed a commit that referenced this pull request Jan 12, 2026
…kflow matrix (#11958)

**This is a backport of PR #11938 as merged into master
(d09103a).**

Co-authored-by: AraHaan <[email protected]>
@AraHaan
Copy link
Contributor Author

AraHaan commented Jan 13, 2026

I hate to ask this here but when will 3.14 of aiohttp be released?

@Dreamsorcerer
Copy link
Member

I think we'll be aiming for a few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing win_arm64 wheels for aiohttp.

3 participants