-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add Windows 11 ARM64 to CI/CD workflow matrix #11938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The win_arm64 wheels were not getting built and published to pypi. Fixes aio-libs#11937.
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11938 +/- ##
==========================================
+ Coverage 98.73% 98.75% +0.02%
==========================================
Files 127 127
Lines 44581 44581
Branches 2358 2358
==========================================
+ Hits 44019 44028 +9
+ Misses 399 393 -6
+ Partials 163 160 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
More changes might be needed in the workflow file to add |
|
This is probably enough for now. Just a change note's needed. In the future, it'd be good to replicate the approach with reusable workflows from multidict/yarl/etc. |
Added win_arm64 to the wheels that gets pushed to PyPI
Backport to 3.14: 💚 backport PR created✅ Backport PR branch: Backported as #11958 🤖 @patchback |
(cherry picked from commit d09103a)
…kflow matrix (#11958) **This is a backport of PR #11938 as merged into master (d09103a).** Co-authored-by: AraHaan <[email protected]>
|
I hate to ask this here but when will 3.14 of aiohttp be released? |
|
I think we'll be aiming for a few weeks. |
What do these changes do?
This adds the Windows 11 arm64 runner image for github actions to the CI/CD workflow matrix to ensure that the win_arm64 wheel gets built. Without this I cannot use
--platformthat passes inwin_arm64into pip to install all of the packages in myrequirements.txtwhich includediscord.py,asqlite, andaiohttp. With this change there is a chance that aiohttp could get a win_arm64 wheel published to pypi just like withyarlandmultidictto name a few binary packages that are dependencies of aiohttp.Are there changes in behavior for the user?
No changes, other than allowing one to pip install aiohttp using it's
--platformargument which forces install from wheels as the only valid option, without arm64 wheels it will try to install version0.13.1of aiohttp which is not supported in many packages (many packages supportsaiohttp<4,>=3.7.4,only).Is it a substantial burden for the maintainers to support this?
Nope, all this does is adds the new arm64 windows github actions runner to build the win_arm64 wheel for publish to pypi.
Related issue number
Fixes #11937
Checklist
CONTRIBUTORS.txt(No code changes are provided.)CHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.