[PR #11938/d09103a5 backport][3.14] Add Windows 11 ARM64 to CI/CD workflow matrix #11958
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #11938 as merged into master (d09103a).
What do these changes do?
This adds the Windows 11 arm64 runner image for github actions to the CI/CD workflow matrix to ensure that the win_arm64 wheel gets built. Without this I cannot use
--platformthat passes inwin_arm64into pip to install all of the packages in myrequirements.txtwhich includediscord.py,asqlite, andaiohttp. With this change there is a chance that aiohttp could get a win_arm64 wheel published to pypi just like withyarlandmultidictto name a few binary packages that are dependencies of aiohttp.Are there changes in behavior for the user?
No changes, other than allowing one to pip install aiohttp using it's
--platformargument which forces install from wheels as the only valid option, without arm64 wheels it will try to install version0.13.1of aiohttp which is not supported in many packages (many packages supportsaiohttp<4,>=3.7.4,only).Is it a substantial burden for the maintainers to support this?
Nope, all this does is adds the new arm64 windows github actions runner to build the win_arm64 wheel for publish to pypi.
Related issue number
Fixes #11937
Checklist
CONTRIBUTORS.txt(No code changes are provided.)CHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.