Skip to content

Comments

Fix: include index in glyphs prop#1978

Open
TychosDrunkElk wants to merge 2 commits intoairbnb:masterfrom
TychosDrunkElk:include-glyph-index
Open

Fix: include index in glyphs prop#1978
TychosDrunkElk wants to merge 2 commits intoairbnb:masterfrom
TychosDrunkElk:include-glyph-index

Conversation

@TychosDrunkElk
Copy link

🐛 Bug Fix

  • The glyphprops type already has an index, but this doesn't currently get set in the BaseGlyphSeries. Adds the index, and ensures glyphs satisfy the type

@TychosDrunkElk
Copy link
Author

Hi @hshoff 👋 This is a minor issue I ran into, currently getting around it by parsing key. Since the type for GlyphProps has the index, I'm assuming it just needs to be added here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant