Skip to content

Fix: include index in glyphs prop #1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TychosDrunkElk wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −3
Open

Fix: include index in glyphs prop #1978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6969ac2
Fix: include index in glyphs prop
TychosDrunkElk Jan 6, 2026
3edc430
ensure type is correct for GlyphProps
TychosDrunkElk Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/visx-xychart/src/components/series/private/BaseGlyphSeries.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,15 @@ export function BaseGlyphSeries<
if (!isValidNumber(y)) return null;
return {
key: `${i}`,
index: i,
x,
y,
color: colorAccessor?.(datum, i) ?? color,
size: typeof size === 'function' ? size(datum) : size,
datum,
};
})
.filter((point) => point) as GlyphProps<Datum>[],
.filter((point) => !!point) satisfies GlyphProps<Datum>[],
[color, colorAccessor, data, getScaledX, getScaledY, size],
);

Expand Down
11 changes: 9 additions & 2 deletions packages/visx-xychart/test/components/GlyphSeries.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { vi } from 'vitest';
import React, { useContext, useEffect } from 'react';
import { render, waitFor } from '@testing-library/react';
import '@testing-library/jest-dom';
import type { GlyphProps } from '../../src';
import { AnimatedGlyphSeries, DataContext, GlyphSeries, useEventEmitter } from '../../src';
import getDataContext from '../mocks/getDataContext';
import setupTooltipTest from '../mocks/setupTooltipTest';
Expand Down Expand Up @@ -59,15 +60,21 @@ describe('<GlyphSeries />', () => {
});

it('should render a custom Glyph for each Datum', () => {
const customRenderGlyph = () => <rect className="custom-glyph" />;
const customRenderGlyph = (props: GlyphProps<{}>) => (
<rect className="custom-glyph" data-index={props.index} />
);
const { container } = render(
<DataContext.Provider value={getDataContext({ key: 'glyph', ...series })}>
<svg>
<GlyphSeries dataKey={'glyph'} {...series} renderGlyph={customRenderGlyph} />
</svg>
</DataContext.Provider>,
);
expect(container.querySelectorAll('.custom-glyph')).toHaveLength(series.data.length);
const glyphs = container.querySelectorAll('.custom-glyph');

expect(glyphs).toHaveLength(series.data.length);
expect(glyphs[0]).toHaveAttribute('data-index', '0');
expect(glyphs[1]).toHaveAttribute('data-index', '1');
});

it('should invoke showTooltip/hideTooltip on pointermove/pointerout', async () => {
Expand Down